travis: Remove s390x build #20315

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2010-ciS390x changing 3 files +3 −9
  1. MarcoFalke commented at 11:53 am on November 5, 2020: member

    This has been discussed in the last meeting.

    Refer to the commit body for more details.

  2. travis: Remove s390x build
    The build didn't find too many issues, and they are generally only
    endianness related, so easy to fix if they do make it into the main
    developement branch.
    
    With travis migrating its service, it fails too often intermittently. It
    might be more appropriate to run it manually once before every release.
    fac0517836
  3. ci: Set LC_ALL=C to allow running the s390x tests in qemu
    Without the fix, the tests immediately abort:
    
    terminate called after throwing an instance of 'std::runtime_error'
      what():  locale::facet::_S_create_c_locale name not valid
    ./qt/test/test_bitcoin-qt: line 2: 116150 Aborted
    fa2c3c0d96
  4. MarcoFalke force-pushed on Nov 5, 2020
  5. fanquake added the label Tests on Nov 5, 2020
  6. DrahtBot commented at 9:19 pm on November 5, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19179 ([WIP RFC DONOTMERGE] ci: Run ci configs on cirrus by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. hebasto commented at 9:58 am on November 6, 2020: member
    Do I understand correctly that the last commit fixes manual s390x builds?
  8. MarcoFalke commented at 10:18 am on November 6, 2020: member
    It fixes qemu builds. Manual and automatic
  9. decryp2kanon commented at 1:47 pm on November 6, 2020: contributor
    could you explain why we should remove this? @MarcoFalke
  10. MarcoFalke commented at 1:52 pm on November 6, 2020: member
    • Running it on travis has been unreliable (search for s390x issues in this repo)
    • travis org is shutting down and there is no s390x on travis com
    • the test is more meaningful if run either locally in qemu or on any other arch that has different endianness
  11. decryp2kanon commented at 2:36 pm on November 6, 2020: contributor
    Concept ACK
  12. MarcoFalke merged this on Nov 6, 2020
  13. MarcoFalke closed this on Nov 6, 2020

  14. MarcoFalke deleted the branch on Nov 6, 2020
  15. in .travis.yml:79 in fa2c3c0d96
    71@@ -72,13 +72,6 @@ jobs:
    72         FILE_ENV="./ci/test/00_setup_env_arm.sh"
    73         QEMU_USER_CMD=""
    74 
    75-    - stage: test
    76-      name: 'S390x  [GOAL: install]  [buster]  [unit tests, functional tests]'
    77-      arch: s390x  # Can disable QEMU_USER_CMD and run the tests natively without qemu
    78-      env: >-
    79-        FILE_ENV="./ci/test/00_setup_env_s390x.sh"
    


    decryp2kanon commented at 5:35 pm on November 6, 2020:
    this file is removing too? ci/test/00_setup_env_s390x.sh

    MarcoFalke commented at 5:38 pm on November 6, 2020:
    I’d like to keep it so that it can be executed easier, if needed
  16. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-04 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me