Fix duplicate shortcut usage in sign/verify message dialog. #2032

pull burger2 wants to merge 1 commits into bitcoin:master from burger2:fix_shortcut changing 1 files +2 −2

burger2 commented at 10:33 PM on November 22, 2012: contributor

This fixes the duplicate shortcut usage in sign(alt+s)/verify(alt+v) message dialog.

Bug described in issue: #1927
Fix duplicate shortcut usage in sign/verify message dialog. ecd67a1420
Diapolo commented at 11:49 AM on November 23, 2012: none

ACK
BitcoinPullTester commented at 10:47 PM on November 24, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ecd67a142066ba7e5e2a92d152cb8bfb156d6f69 for binaries and test log.
burger2 commented at 9:19 PM on December 18, 2012: contributor

Will this fix still work after all the commits done lately?
Diapolo commented at 10:28 PM on December 18, 2012: none

Yes, as there were no recent changes to signverifymessagedialog.ui this commit will merge just fine to current master. @laanwj Ping :)
Diapolo commented at 2:05 AM on January 1, 2013: none

Can we get this merged please?
sipa commented at 6:11 PM on January 1, 2013: member

This seems to change both sign and verify to alt-m ?
Diapolo commented at 6:58 PM on January 1, 2013: none

@sipa Indeed, but they are on different tabs and each tab is reached by the now changed shortcut, so that we now have a shortcut to reach the tab and a shortcut to execute the sign or verify :).
laanwj commented at 7:21 PM on January 1, 2013: member

Tested: indeed, typing alt-m triggers the shortcut in the current tab
laanwj referenced this in commit 15ffcc3642 on Jan 1, 2013
laanwj merged this on Jan 1, 2013
laanwj closed this on Jan 1, 2013
laudney referenced this in commit cf506aae46 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#1927 Keyboard shortcut duplicate in sign/verify message window.