tests: Fix ecdsa_verify in test framework #20326

pull stepansnigirev wants to merge 1 commits into bitcoin:master from stepansnigirev:fix-test-ecdsa-verification changing 1 files +1 −1
  1. stepansnigirev commented at 10:27 PM on November 5, 2020: contributor

    This PR fixes a small bug in the test framework in verify_ecdsa function. r in ecdsa signature is modulo curve order, so if the point R calculated during verification has x-coordinate that is larger than the curve order, the verification will fail in the test framework but pass in libsecp256k1.

    Example (all in hex): public key: 0289d889551598a0263746c01e5882ccf9b7dc4ca5a37108482c9d80de40e0a8cf der signature: 3006020104020104 (r = 4, s = 4) message: 3232323232323232323232323232323232323232323232323232323232323232

    libsecp256k1 returns true, test framework returns false.

  2. fix ecdsa verify in test framework 568a1d7261
  3. fanquake added the label Tests on Nov 5, 2020
  4. sipa commented at 11:45 PM on November 5, 2020: member

    utACK 568a1d72619371a45b14a8356d3f80bd0c0efabc

  5. MarcoFalke merged this on Nov 6, 2020
  6. MarcoFalke closed this on Nov 6, 2020

  7. stepansnigirev deleted the branch on Nov 6, 2020
  8. sidhujag referenced this in commit 82d1a1f05b on Nov 6, 2020
  9. PastaPastaPasta referenced this in commit 017f5e0325 on Dec 22, 2021
  10. PastaPastaPasta referenced this in commit ff105093f4 on Dec 22, 2021
  11. PastaPastaPasta referenced this in commit a275264008 on Dec 22, 2021
  12. PastaPastaPasta referenced this in commit 618203e693 on Dec 28, 2021
  13. DrahtBot locked this on Feb 15, 2022
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me