Avoid pruning blocks with transactions in wallets (even after wallets sync) #20384

issue luke-jr opened this issue on November 13, 2020

luke-jr commented at 7:20 PM on November 13, 2020: member
Good idea from @Bosch-0: https://github.com/bitcoin-core/gui/pull/125#issuecomment-723806881

By not pruning blocks that contain wallet transactions, old backups can be restored despite pruning.

Logical dependencies:
- My current prune-locks PR only works with heights, whereas this should probably be based on block hash.
- Some way to sort out if this was done, when restoring a backup, so we know it's safe to assume missing blocks are ignorable.
luke-jr added the label Feature on Nov 13, 2020
Bosch-0 commented at 4:02 AM on November 19, 2020: none

How would (could you?) you know a block contains relevant transactions if the wallet is not yet imported?
luke-jr commented at 4:50 AM on November 19, 2020: member

This would only be useful for restoring backups (ie, the wallet was loaded during pruning).
pinheadmz commented at 8:00 PM on March 31, 2023: member

This looks like another issue that could be addressed by https://github.com/bitcoin/bitcoin/issues/21267
pinheadmz assigned pinheadmz on Jun 2, 2023

Contributors

Labels