Revert “Merge #19606: Backport wtxid relay to v0.20” #20399

pull MarcoFalke wants to merge 1 commits into bitcoin:0.20 from MarcoFalke:2011-prepare020release changing 19 files +101 −444
  1. MarcoFalke commented at 6:51 am on November 16, 2020: member

    The 0.20 branch has bugfixes that should be released. However, a tag can currently not be created because the latest merge introduced a regression and is not a bugfix (https://github.com/bitcoin/bitcoin/pull/20317#issuecomment-723754509, #20317 (comment)).

    Fix that by reverting the last merge. Can be reviewed by re-doing the revert or calling git diff HEAD HEAD~2 | wc and observing an empty diff.

  2. Revert "Merge #19606: Backport wtxid relay to v0.20"
    This reverts commit a339289c2ef9caffa1195436695a13f6e48e1bbc, reversing
    changes made to b9ac31f2d29ae3e79c0f0cde5bab2d7213e6da51.
    fa074d2c7b
  3. DrahtBot added the label Backport on Nov 16, 2020
  4. jnewbery commented at 9:42 am on November 16, 2020: member
    It seems odd to revert a feature that’s already been reviewed and merged. If we think this is unsafe it should also be reverted in the master branch.
  5. MarcoFalke commented at 10:14 am on November 16, 2020: member

    #20317 has no ACKs so far, so it can’t be merged right now. It is holding back the next minor release which has already quite a few bugfixes waiting to be shipped.

    I can’t vouch whether the backport is safe or unsafe, but we’ve never delayed a bugfix release to backport a feature. Also, I think this is the first time ever that a feature was backported to a bugfix release and released before it was released in a major version.

    If #20317 gets enough review to make it into the release, fine by me. Otherwise the milestone will simply be adjusted by one minor version. Also, no review will be lost. Observing and ACKing an empty diff can be done by anyone.

  6. MarcoFalke added this to the milestone 0.20.2 on Nov 18, 2020
  7. MarcoFalke commented at 9:09 am on November 18, 2020: member
    (appveyor failure can be ignored, as it is caused by appveyor bumping the compiler version)
  8. adamjonas commented at 4:48 pm on November 18, 2020: member
    Linking to relevant notes from this week’s p2p IRC meeting on reverting #19606.
  9. laanwj commented at 1:50 pm on November 23, 2020: member

    Code review ACK fa074d2c7b9c3d34876c428d12672a505d4ce4eb

    0$ git fetch upstream pull/20399/head
    1$ git checkout FETCH_HEAD
    2$ git diff HEAD HEAD~2 | wc -l
    30
    

    (this doesn’t work with the merge of this PR to the branch because there was an intermediate merge of #20166 in between, but that’s okay, it still applies cleanly)

  10. MarcoFalke merged this on Nov 23, 2020
  11. MarcoFalke closed this on Nov 23, 2020

  12. MarcoFalke deleted the branch on Nov 23, 2020
  13. MarkLTZ referenced this in commit a89e884d5e on Nov 26, 2020
  14. MarkLTZ referenced this in commit a133cbacaf on Nov 26, 2020
  15. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me