This PR removes the following tokens from translatable strings:
All of them are untranslatable by their nature.
The Translation Strings Policy updated accordingly.
This was done while reviewing #20401. Good to get it just after 0.21 branch off :)
Command line option name must not be a part of the translatable string,
as it is untranslatable by its nature.
RPC name must not be a part of the translatable string, as it is
untranslatable by its nature.
Added requirement to do not translate names.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ACK c20e3db
Good idea :+1:
4040@@ -4041,7 +4041,7 @@ std::shared_ptr<CWallet> CWallet::Create(interfaces::Chain& chain, const std::st
4041 }
4042
4043 if (rescan_height != block_height) {
4044- error = _("Prune: last wallet synchronisation goes beyond pruned data. You need to -reindex (download the whole blockchain again in case of pruned node)");
4045+ error = strprintf(_("Prune: last wallet synchronisation goes beyond pruned data. You need to %s (download the whole block chain again in case of pruned node)."), "-reindex");
1419@@ -1416,16 +1420,16 @@ bool AppInitMain(const util::Ref& context, NodeContext& node, interfaces::BlockA
1420 }
1421 strSubVersion = FormatSubVersion(CLIENT_NAME, CLIENT_VERSION, uacomments);
1422 if (strSubVersion.size() > MAX_SUBVERSION_LENGTH) {
1423- return InitError(strprintf(_("Total length of network version string (%i) exceeds maximum length (%i). Reduce the number or size of uacomments."),
1424- strSubVersion.size(), MAX_SUBVERSION_LENGTH));
1425+ return InitError(strprintf(_("Total length of network version string (%i) exceeds maximum length (%i). Reduce the number or size of %s."),
0 return InitError(strprintf(_("Total length of network version string (%i) exceeds maximum length (%i). Reduce the number or size of %s options."),
29@@ -30,6 +30,15 @@ This includes messages passed to the GUI through the UI interface through `InitM
30 General recommendations
31 ------------------------
32
33+### Do not translate names
34+
35+The following tokens must not be parts of the strings are to be translated:
36+- command line option names
37+- RPC names
0- RPC method and parameter names
1025+ if (args.GetBoolArg("-txindex", DEFAULT_TXINDEX)) {
1026+ return InitError(strprintf(_("Prune mode is incompatible with %s."), "-txindex"));
1027+ }
1028 if (!g_enabled_filter_types.empty()) {
1029- return InitError(_("Prune mode is incompatible with -blockfilterindex."));
1030+ return InitError(strprintf(_("Prune mode is incompatible with %s."), "-blockfilterindex"));
ResolveErrMsg)?
1200@@ -1197,7 +1201,7 @@ bool AppInitParameterInteraction(const ArgsManager& args)
1201 nMaxTipAge = args.GetArg("-maxtipage", DEFAULT_MAX_TIP_AGE);
1202
1203 if (args.IsArgSet("-proxy") && args.GetArg("-proxy", "").empty()) {
1204- return InitError(_("No proxy server specified. Use -proxy=<ip> or -proxy=<ip:port>."));
1205+ return InitError(strprintf(_("No proxy server specified. Use %s or %s."), "-proxy=<ip>", "-proxy=<ip:port>"));
=<ip:port> parts?
1456
1457 proxyType addrProxy = proxyType(proxyAddr, proxyRandomize);
1458- if (!addrProxy.IsValid())
1459- return InitError(strprintf(_("Invalid -proxy address or hostname: '%s'"), proxyArg));
1460+ if (!addrProxy.IsValid()) {
1461+ return InitError(strprintf(_("Invalid %s address or hostname: '%s'"), "-proxy", proxyArg));
1480 }
1481 proxyType addrOnion = proxyType(onionProxy, proxyRandomize);
1482- if (!addrOnion.IsValid())
1483- return InitError(strprintf(_("Invalid -onion address or hostname: '%s'"), onionArg));
1484+ if (!addrOnion.IsValid()) {
1485+ return InitError(strprintf(_("Invalid %s address or hostname: '%s'"), "-onion", onionArg));
2960@@ -2961,7 +2961,7 @@ bool CWallet::CreateTransactionInternal(
2961 nFeeNeeded = GetMinimumFee(*this, nBytes, coin_control, &feeCalc);
2962 if (feeCalc.reason == FeeReason::FALLBACK && !m_allow_fallback_fee) {
2963 // eventually allow a fallback fee
2964- error = _("Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.");
2965+ error = strprintf(_("Fee estimation failed. %s is disabled. Wait a few blocks or enable %s."), "-fallbackfee", "-fallbackfee");
3934@@ -3935,7 +3935,7 @@ std::shared_ptr<CWallet> CWallet::Create(interfaces::Chain& chain, const std::st
3935 if (gArgs.IsArgSet("-discardfee")) {
3936 CAmount nFeePerK = 0;
3937 if (!ParseMoney(gArgs.GetArg("-discardfee", ""), nFeePerK)) {
3938- error = strprintf(_("Invalid amount for -discardfee=<amount>: '%s'"), gArgs.GetArg("-discardfee", ""));
3939+ error = strprintf(_("Invalid amount for %s=<amount>: '%s'"), "-discardfee", gArgs.GetArg("-discardfee", ""));
Concept ACK
Doesn’t this make it much harder for translators to understand what is being translated? A lot of context information goes missing by replacing these with placeholders.
Qt lets you specify an additional string seen only by translators for context. Does Transifex support that? Can we add it to our utils too?
🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.
I understand the idea but… Doesn’t this make it much harder for translators to understand what is being translated? A lot of context information goes missing by replacing these with placeholders.
I understand your concerns. Yes, translators will lose some part of context with this approach. OTOH, for https://github.com/bitcoin/bitcoin/blob/7d8a10a6f4d61df1f4afb138e379149565afa02d/src/init.cpp#L1200
just spotted the following translation:
(the most common kind of question that I get on transifex is already “I don’t understand the context of this message, please explain”. It might also result in less specific and relevant translations.)
Does answering those questions resolve translators’ lack of context?
Does answering those questions resolve translators’ lack of context?
Not really—in the sense that it’s not a scalable approach, and also many will not ask and just assume something (often wrongly). If there is some other way to provide context that is shown in the translator (like the translation comment) I guess that would work though.
If there is some other way to provide context that is shown in the translator (like the translation comment) I guess that would work though.
DEVELOPER NOTES… These types of notes are added to source files by developers. Not all file formats support developer notes though. The file types which support developer notes are the following: Android XML, Apple PLIST, Apple Strings, JSON (Chrome), Structured JSON, PO, Mozilla DTD, Windows Resx, Resw and Resjson, Xliff, xlsx (as context) and YAML.
Qt files are not mentioned, unfortunately.