tests: shrink feature_taproot transfer of funds tx #20428

1. 
   ajtowns commented at 8:13 PM on November 19, 2020: member

   When moving funds from node 1 to node 0 for the pre-activation tests, there can be a large number of inputs, potentially resulting in a tx that is larger than standardness rules allow, or that takes a long time to sign. This just takes the top 500 outputs, which is plenty (~90% of the wallet balance).

2. DrahtBot added the label Tests on Nov 19, 2020
3. luke-jr approved
4. 
   luke-jr commented at 8:52 PM on November 19, 2020: member

   tACK e68d3324f7ce821516b7b232cdd74add861ae78e

5. 
   jonatack commented at 8:57 PM on November 19, 2020: member

   Concept ACK, testing.

6. ajtowns force-pushed on Nov 19, 2020
7. 
   jonatack commented at 9:15 PM on November 19, 2020: member

   On a sluggish Intel Core i7-6500U CPU @ 2.50GHz × 4, two runs each, ~28 seconds faster

   master
   real	4m8.402s
   user	5m30.459s
   sys     0m12.095s
   
   patch
   real	3m39.194s
   user	4m52.800s
   sys	    0m12.868s
   
   master
   real	3m58.595s
   user	5m15.567s
   sys	    0m12.140s
   
   patch
   real	3m31.601s
   user	4m47.992s
   sys	    0m12.036s
   

8. 
   luke-jr commented at 9:18 PM on November 19, 2020: member

   re-tACK ed8745a6f827791aee55764b44682fea8987017d

9. 
   jonatack commented at 9:24 PM on November 19, 2020: member

   ACK ed8745a6f827791aee55764b44682fea8987017d

10. tests: shrink feature_taproot transfer of funds tx 7ffac12545
11. ajtowns force-pushed on Nov 19, 2020
12. 
    ajtowns commented at 9:36 PM on November 19, 2020: member

    Rebased further back in history so it's easy to backport to 0.21, and simplified to just pick the 500 unspents with the highest amount, rather than doing many transactions.

13. ajtowns renamed this:
    tests: split feature_taproot transfer of funds into smaller txs
    tests: shrink feature_taproot transfer of funds tx
    on Nov 19, 2020
14. 
    luke-jr commented at 10:24 PM on November 19, 2020: member

    utACK 7ffac12545328cadd92a3caec4f1c6ca7c127493

15. 
    sipa commented at 10:26 PM on November 19, 2020: member

    utACK

16. MarcoFalke added the label Needs backport (0.21) on Nov 20, 2020
17. MarcoFalke added this to the milestone 0.21.1 on Nov 20, 2020
18. MarcoFalke removed this from the milestone 0.21.1 on Nov 20, 2020
19. MarcoFalke added this to the milestone 0.21.0 on Nov 20, 2020
20. 
    MarcoFalke commented at 8:28 AM on November 20, 2020: member

    cr ACK 7ffac12545328cadd92a3caec4f1c6ca7c127493

21. MarcoFalke merged this on Nov 20, 2020
22. MarcoFalke closed this on Nov 20, 2020

    ---

23. MarcoFalke removed the label Needs backport (0.21) on Nov 20, 2020
24. 
    MarcoFalke commented at 8:33 AM on November 20, 2020: member

    backported in #20431

25. MarcoFalke referenced this in commit bf9548bc59 on Nov 20, 2020
26. sidhujag referenced this in commit b6d7c2bd4b on Nov 20, 2020
27. DrahtBot locked this on Feb 15, 2022

Contributors

ajtownsluke-jrjonatacksipaMarcoFalke

Milestone
0.21.0