Intended to at least mitigate the issue from #2035.
do not silently ignore errors on "backupwallet" RPC cmd #2044
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:backupwallet changing 1 files +2 −1-
Diapolo commented at 3:30 PM on November 27, 2012: none
-
do not silently ignore errors on "backupwallet" RPC cmd ad525e9c8f
-
laanwj commented at 3:33 PM on November 27, 2012: member
ACK Though I guess we still have to verify that backupwallet indeed returns false in the can't-overwrite case
-
Diapolo commented at 3:37 PM on November 27, 2012: none
@laanwj Yeah, this is not the fix for the underlying problem (if there is one), but an easy addition anyway :).
So perhaps Boost is the problem here, I'm thinking of the second path in BackupWallet().
<pre> #if BOOST_VERSION >= 104000 filesystem::copy_file(pathSrc, pathDest, filesystem::copy_option::overwrite_if_exists); #else filesystem::copy_file(pathSrc, pathDest); #endif </pre>
-
BitcoinPullTester commented at 5:48 PM on November 27, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ad525e9c8fa2b15f1afe6b7284de638a090e891a for binaries and test log.
-
Joukehofman commented at 11:22 PM on November 27, 2012: none
boost v1.42.
I compiled your code and tested it on my case. It shows an error now :-) .
I don't know what versions of libboost was used on 6.3 and 6.2, but I had the same problem with those precompiled versions.
- laanwj referenced this in commit 5c37be2db6 on Nov 28, 2012
- laanwj merged this on Nov 28, 2012
- laanwj closed this on Nov 28, 2012
-
- laudney referenced this in commit 88aae3d3e2 on Mar 19, 2014
- DrahtBot locked this on Sep 8, 2021
