Don’t set BDB flags when configuring without #20478

1. 
   jonasschnelli commented at 2:13 pm on November 24, 2020: contributor

   Configuring --without-bdb on MacOS leads to a compile error (when BerkeleyDB is not installed). brew --prefix berkeley-db4 always reports the target directory (even if not installed).

   This PR prevents BDB_CFLAGS (et al) from being populated when configuring --without-bdb

   0ld: warning: directory not found for option '-L/Users/user/Documents/homebrew/Cellar/berkeley-db@4/4.8.30/lib'
   1ld: warning: directory not found for option '-L/Users/user/Documents/homebrew/Cellar/berkeley-db@4/4.8.30/lib'
   2ld: library not found for -ldb_cxx-4.8
   3ld: library not found for -ldb_cxx-4.8
   

2. Don't set BDB flags when configuring without 982e548a9a
3. jonasschnelli added the label macOS on Nov 24, 2020
4. jonasschnelli added the label Build system on Nov 24, 2020
5. 
   jonasschnelli commented at 2:14 pm on November 24, 2020: contributor

   Missed in #20202.
6. 
   promag commented at 3:38 pm on November 24, 2020: member

   Tested ACK 982e548a9a78b1b0abad59b54c780b6b06570452.
7. in configure.ac:644 in 982e548a9a

   642@@ -643,7 +643,7 @@ case $host in
   643 
   644          bdb_prefix=$($BREW --prefix berkeley-db4 2>/dev/null)
   

   ---

   ---

   

   laanwj commented at 3:44 pm on November 24, 2020:

   I guess it shouldn’t even call brew here in case bdb is not used?

   ---

   

   jonasschnelli commented at 4:40 pm on November 24, 2020:

   brew just returns the expected directory (based on the available - also uninstalled – formulas). But we could also just avoid the brew call (complicated the folding though…)
8. hebasto approved
9. 
   hebasto commented at 10:55 am on November 25, 2020: member

   ACK 982e548a9a78b1b0abad59b54c780b6b06570452, tested on macOS 11 Big Sur.
10. 
    DrahtBot commented at 2:26 pm on November 29, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20527 (build: Do not ignore Homebrew’s SQLite on macOS by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. jonasschnelli merged this on Dec 1, 2020
12. jonasschnelli closed this on Dec 1, 2020

    ---

13. sidhujag referenced this in commit f64c83ddcb on Dec 1, 2020
14. jonasschnelli referenced this in commit 257cf05f9b on Dec 4, 2020
15. 
    hebasto commented at 11:13 am on December 4, 2020: member

    ~It seems this change is no longer required since #20563 has been merged. Maybe revert it as a part of #20527?~

    nm

16. MarcoFalke referenced this in commit 61e316e661 on Dec 10, 2020
17. 
    MarcoFalke commented at 1:14 pm on December 10, 2020: member

    Backported in #20612 because #20527 has been marked for backport
18. DrahtBot locked this on Feb 15, 2022

Contributors
jonasschnelli promag laanwj hebasto DrahtBot MarcoFalke

Labels
macOS Build system