build: Check that Homebrew’s berkeley-db4 package is actually installed #20563

1. 
   hebasto commented at 9:46 pm on December 3, 2020: member

   On master (a0489f3472f3799dc1ece32a59556fd239c4c14b) the configure script is not able to determine that Homebrew’s berkeley-db4 package is uninstalled. This causes a compile error on macOS.

   With this PR, and with the uninstalled berkeley-db4 package:

   0% ./configure -q                  
   1configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support)
   

   Related #20478.

2. build: Check that Homebrew's berkeley-db4 package is actually installed d3ef947524
3. 
   hebasto commented at 9:47 pm on December 3, 2020: member

   cc @jonasschnelli
4. DrahtBot added the label Build system on Dec 3, 2020
5. 
   DrahtBot commented at 0:25 am on December 4, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20527 (build: Do not ignore Homebrew’s SQLite on macOS by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   promag commented at 8:56 am on December 4, 2020: member

   Tested ACK d3ef947524a07f8d7fbad5b95781ab6cacb1cb49.

   0$ brew list --versions berkeley-db4
   1$ ./autogen.sh && ./configure
   2checking for Berkeley DB C++ headers... no
   3configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support)
   

7. willcl-ark approved
8. 
   willcl-ark commented at 8:59 am on December 4, 2020: member

   tACK d3ef947524a07f8d7fbad5b95781ab6cacb1cb49

   0will in bitcoin on  201203-bdb [$?] via 🐍 3.6.12 ➜ ./configure -q --without-gui
   1configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support)
   

9. jonasschnelli approved
10. 
    jonasschnelli commented at 9:07 am on December 4, 2020: contributor

    Thanks for the cleanup. This is much nicer.

    utACK d3ef947524a07f8d7fbad5b95781ab6cacb1cb49

11. jonasschnelli merged this on Dec 4, 2020
12. jonasschnelli closed this on Dec 4, 2020

    ---

13. hebasto deleted the branch on Dec 4, 2020
14. sidhujag referenced this in commit 168b7fadda on Dec 4, 2020
15. MarcoFalke referenced this in commit 96124a2041 on Dec 10, 2020
16. 
    MarcoFalke commented at 1:15 pm on December 10, 2020: member

    Backported in #20612 because #20527 has been marked for backport
17. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto DrahtBot promag willcl-ark jonasschnelli MarcoFalke

Labels
Build system