doc: libconsensus: add missing error code description, fix NBitcoin link #20577

pull theStack wants to merge 1 commits into bitcoin:master from theStack:201212-doc-libbitcoinconsensus-fixes changing 1 files +2 −1

theStack commented at 1:01 PM on December 5, 2020: member
This PR improves the libbitcoinconsensus description in shared-libraries.md in two ways:
- adds the missing error code description for bitcoinconsensus_ERR_INVALID_FLAGS (introduced by commit 5ca8ef299a08aae91d5061750533694b58d810b2, PR #8976)
- updates and fixes the link to the NBitcoin implementation (introduced by commit 3361edd01046aab137928d1e6e2468dbfc4b946e, PR #6430)
  
  the owner of the NBitcoin github repository changed from NicolasDorier to MetacoSA (redirection still worked though)
  
  instead of dynamically referring to a file in master with a fixed line number (which is obviously always quickly outdated), use a permalink with a file numbers area
doc: libbitcoinconsensus: add missing error code description, fix NBitcoin link cb0b7125c1
fanquake added the label Docs on Dec 5, 2020
DrahtBot commented at 10:14 AM on December 6, 2020: member



🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.
MarcoFalke commented at 10:28 AM on December 6, 2020: member

cr ACK cb0b7125c14bf97394bd8b43bf2abfb943bb1cf9
harding commented at 7:51 PM on December 6, 2020: contributor

Code (documentation) review ACK cb0b7125c14bf97394bd8b43bf2abfb943bb1cf9. Text is clear and seems accurate, and the link checks out.
fanquake merged this on Dec 7, 2020
fanquake closed this on Dec 7, 2020
DrahtBot locked this on Feb 15, 2022
theStack deleted the branch on Jan 10, 2023

Contributors

Labels

Linked (view graph)

#6430 doc: add documentation for shared library libbitcoinconsensus #8976 libconsensus: Add input validation of flags