rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs #20583

1. 
   MarcoFalke commented at 6:54 pm on December 6, 2020: member

   Wallet RPCs that allow a rescan based on block-timestamp or block-height need to sync with the active chain first, because the user might assume the wallet is up-to-date with the latest block they got reported via a blockchain RPC.
2. DrahtBot added the label RPC/REST/ZMQ on Dec 6, 2020
3. DrahtBot added the label Wallet on Dec 6, 2020
4. 
   luke-jr commented at 9:37 pm on December 13, 2020: member

   Wouldn’t it make more sense to do this conditional on that particular use case?
5. 
   luke-jr commented at 9:44 pm on December 13, 2020: member

   Actually, when would this matter at all? If the wallet is on a stale chain, the process of reorganising should do the rescan for the user anyway?
6. 
   MarcoFalke commented at 7:44 am on December 14, 2020: member

   Actually, when would this matter at all?

   When you pass in the height or time of a block in the active chain that the wallet hasn’t yet caught up with. For example, the active chain is at height=100, the wallet at height=90. A user specifies a range to rescan=[95,100], which wouldn’t succeed.

7. 
   DrahtBot commented at 1:47 pm on March 2, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23667 (Split up rpcwallet by meshcollider)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. DrahtBot added the label Needs rebase on Mar 10, 2021
9. MarcoFalke force-pushed on Mar 10, 2021
10. DrahtBot removed the label Needs rebase on Mar 10, 2021
11. DrahtBot added the label Needs rebase on Dec 3, 2021
12. MarcoFalke force-pushed on Dec 3, 2021
13. rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs

    Wallet RPCs that allow a rescan based on block-timestamp or block-height
    need to sync with the active chain first, because the user might assume
    the wallet is up-to-date with the latest block they got reported via a
    blockchain RPC.

    fa5362a9a0
14. MarcoFalke force-pushed on Dec 3, 2021
15. DrahtBot removed the label Needs rebase on Dec 3, 2021
16. 
    meshcollider commented at 1:31 am on December 6, 2021: contributor

    utACK fa5362a9a0c5665c1a4de51c3ce4758c93a9449e
17. MarcoFalke merged this on Dec 7, 2021
18. MarcoFalke closed this on Dec 7, 2021

    ---

19. MarcoFalke deleted the branch on Dec 7, 2021
20. fanquake deleted a comment on Dec 7, 2021
21. sidhujag referenced this in commit 95a368276b on Dec 7, 2021
22. RandyMcMillan referenced this in commit 8635ad5990 on Dec 23, 2021
23. DrahtBot locked this on Dec 7, 2022

Contributors
MarcoFalke luke-jr DrahtBot meshcollider

Labels
Wallet RPC/REST/ZMQ