Move TX_MAX_STANDARD_VERSION to policy #20611

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-mvTxStandardVersion changing 4 files +28 −25

MarcoFalke commented at 10:16 AM on December 10, 2020: member

primitives should only be used for the raw datastructures (parsing and format). It is not the right place to document relay policy.

Move TX_MAX_STANDARD_VERSION to policy

Also remove extraneous whitespace, should be reviewed with --ignore-all-space

fade6195b1

MarcoFalke added the label Refactoring on Dec 10, 2020

in src/policy/policy.h:93 in fade6195b1

  89 | @@ -90,25 +90,32 @@ CAmount GetDustThreshold(const CTxOut& txout, const CFeeRate& dustRelayFee);
  90 |  bool IsDust(const CTxOut& txout, const CFeeRate& dustRelayFee);
  91 |  
  92 |  bool IsStandard(const CScript& scriptPubKey, TxoutType& whichType);
  93 | -    /**

laanwj commented at 11:42 AM on December 10, 2020:

This indentation was weird!

laanwj commented at 12:31 PM on December 10, 2020: member

Agree that primitives.h is for consensus data structures only. Code review ACK fade6195b1c230edd561443637a7bde81c2594a4
lontivero commented at 12:13 AM on December 13, 2020: contributor

Concept ACK https://github.com/bitcoin/bitcoin/pull/20611/commits/fade6195b1c230edd561443637a7bde81c2594a4
luke-jr commented at 4:26 PM on December 14, 2020: member

Concept ACK
laanwj merged this on Dec 15, 2020
laanwj closed this on Dec 15, 2020
sidhujag referenced this in commit d4f28e2614 on Dec 15, 2020
MarcoFalke deleted the branch on Dec 16, 2020
DrahtBot locked this on Aug 16, 2022

Contributors

Labels