Using RPC (wait_for_rpc_connection) has several issue:
- It polls in a loop, which might be slow
- It tries to read the RPC cookie file, which might not be present, thus leading to intermittent issues
Fix both by using Popen.wait
test: Use Popen.wait instead of RPC in assert_start_raises_init_error #20613
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-testFastFailInitError changing 1 files +9 −8-
MarcoFalke commented at 11:30 AM on December 10, 2020: member
-
MarcoFalke commented at 11:31 AM on December 10, 2020: member
Idea by @jonasschnelli
-
laanwj commented at 11:34 AM on December 10, 2020: member
Code review ACK
faf7b05be9c86ee61c39e5314511fe2410128a6bfa918dd537fea775c19a590e5f9161bf51a5839b - laanwj added the label Tests on Dec 10, 2020
-
test: Use Popen.wait instead of RPC in assert_start_raises_init_error fa918dd537
- MarcoFalke force-pushed on Dec 10, 2020
- darosior approved
-
darosior commented at 4:34 PM on December 10, 2020: member
ACK fa918dd537fea775c19a590e5f9161bf51a5839b
- MarcoFalke merged this on Dec 10, 2020
- MarcoFalke closed this on Dec 10, 2020
- MarcoFalke deleted the branch on Dec 10, 2020
- sidhujag referenced this in commit 598cffabee on Dec 10, 2020
- Fabcien referenced this in commit 598b609c9b on Jan 26, 2022
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels