Environment variables and search paths can drastically effect the
operation of build tools.
Include these in our id string to mitigate against false cache hits.
Note to builders: This will invalidate all depends output caches in BASE_CACHE
depends: Improve id string robustness #20629
pull dongcarl wants to merge 3 commits into bitcoin:master from dongcarl:2020-12-improve-depends-id-string changing 3 files +24 −13-
dongcarl commented at 8:29 PM on December 11, 2020: member
- dongcarl added the label Build system on Dec 11, 2020
-
DrahtBot commented at 11:12 PM on December 11, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
laanwj commented at 11:58 AM on December 14, 2020: member
Concept ACK. If I understand it correctly, this includes only specific targeted environment variables and not the entire env?
-
luke-jr commented at 6:04 PM on December 14, 2020: member
gcc -v -E -seems to loseCOLLECT_LTO_WRAPPER... -
dongcarl commented at 8:14 PM on December 14, 2020: member
Concept ACK. If I understand it correctly, this includes only specific targeted environment variables and not the entire env?
Yes! It automatically includes any env var that starts with the name of the tool (e.g.
STRIP_*forstrip), and if there are particular ones we know about (e.g.ZERO_AR_DATE) we can just append it like so:6ee5ee4(#20629) -
dongcarl commented at 8:32 PM on December 14, 2020: member
gcc -v -E -seems to loseCOLLECT_LTO_WRAPPER...Right, perhaps someone knows a better invocation here? I'm guessing
COLLECT_LTO_WRAPPERis omitted because the linker is not going to run? - dongcarl force-pushed on Dec 16, 2020
- dongcarl force-pushed on Dec 16, 2020
-
dongcarl commented at 9:08 PM on December 16, 2020: member
Pushed 4b9aaca598aea561d44215eecd3c4a01d08ddd5a -> f792069bc117f11dff0db11f9386ec216581d2a2
- Added an invocation of CC/CXX with just "-v" to pick up COLLECT_LTO_WRAPPER
- Added comment about COLLECT_LTO_WRAPPER and the weird fd indirection trick
- MarcoFalke added the label Needs gitian build on Dec 17, 2020
- MarcoFalke added the label Needs Guix build on Dec 17, 2020
-
DrahtBot commented at 5:22 AM on December 18, 2020: member
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds
- DrahtBot removed the label Needs Guix build on Dec 18, 2020
-
laanwj commented at 11:52 AM on December 18, 2020: member
Code review ACK f792069bc117f11dff0db11f9386ec216581d2a2
-
DrahtBot commented at 12:22 AM on December 20, 2020: member
<!--a722867cd34abeea1fadc8d60700f111-->
Gitian builds
- DrahtBot removed the label Needs gitian build on Dec 20, 2020
- DrahtBot added the label Needs rebase on Jan 22, 2021
-
b3bdff42b5
build: Proper quoting for var printing targets
Previously, if the value contained syntax that was meaningful to make, the printing would fail. Quoting properly avoids this.
-
4c7d418588
depends: Improve id string robustness
Environment variables and search paths can drastically effect the operation of build tools. Include these in our id string to mitigate against false cache hits.
-
depends: Include GUIX_ENVIRONMENT in id string 5200929bfe
- dongcarl force-pushed on Feb 5, 2021
- DrahtBot removed the label Needs rebase on Feb 5, 2021
- laanwj renamed this:
depends: Improve id string robustness
depends: Improve id string robustness
on Feb 9, 2021 -
laanwj commented at 10:42 AM on February 15, 2021: member
re-ACK 5200929bfe26c549d7da92c0adf8adf61e143416
- laanwj merged this on Feb 15, 2021
- laanwj closed this on Feb 15, 2021
- sidhujag referenced this in commit 58144a8550 on Feb 15, 2021
- DrahtBot locked this on Aug 16, 2022
Labels