chainparams: Add default fixed seeds for signet

MarcoFalke commented at 9:22 am on December 14, 2020: member

This adds some random fixed seeds for signet. They might not work, but it is better than nothing.

MarcoFalke added the label P2P on Dec 14, 2020

MarcoFalke commented at 9:39 am on December 14, 2020: member

Can be tested as specified in #20637 with an empty datadir:

 0
 1... (init)
 2
 3# reading vSeeds:
 4
 52020-12-14T09:33:36Z trying connection ntv3mtqw5wt63red.onion:38333 lastseen=0.0hrs
 62020-12-14T09:33:36Z Cannot create socket for ntv3mtqw5wt63red.onion:38333: unsupported network
 72020-12-14T09:33:37Z trying connection 178.128.221.177 lastseen=0.0hrs
 8...
 92020-12-14T09:33:38Z received: sendaddrv2 (0 bytes) peer=0
102020-12-14T09:33:38Z disconnecting peer=0
11
12
13... (wait)
14
15# reading vFixedSeeds:
16
172020-12-14T09:34:37Z Adding fixed seed nodes as DNS doesn't seem to be available.
182020-12-14T09:34:37Z IP 165.232.44.123 mapped to AS0 belongs to new bucket 527
192020-12-14T09:34:37Z IP 106.157.214.199 mapped to AS0 belongs to new bucket 668
202020-12-14T09:34:37Z IP 31.14.40.19 mapped to AS0 belongs to new bucket 313
212020-12-14T09:34:37Z IP 134.209.26.10 mapped to AS0 belongs to new bucket 668
222020-12-14T09:34:37Z IP 178.128.221.177 mapped to AS0 belongs to new bucket 367
232020-12-14T09:34:37Z IP 103.16.128.63 mapped to AS0 belongs to new bucket 843
242020-12-14T09:34:37Z IP 153.126.143.201 mapped to AS0 belongs to new bucket 744
252020-12-14T09:34:37Z IP 192.241.163.142 mapped to AS0 belongs to new bucket 830
262020-12-14T09:34:37Z trying connection 153.126.143.201:38333 lastseen=292.6hrs
272020-12-14T09:34:37Z Added connection peer=1
282020-12-14T09:34:37Z sending version (103 bytes) peer=1
292020-12-14T09:34:37Z send version message: version 70016, blocks=0, us=[::]:0, peer=1

jonatack commented at 9:42 am on December 14, 2020: member

Maybe for mainnet tor v3 as well for bootstrapping connections in 0.21.0

DrahtBot commented at 9:49 am on December 14, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#21560 (net: Add Tor v3 hardcoded seeds by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj commented at 9:51 am on December 14, 2020: member

Concept ACK

MarcoFalke commented at 9:54 am on December 14, 2020: member

Maybe for mainnet tor v3 as well for bootstrapping connections in 0.21.0

I’ll leave that for a follow-up

Saibato commented at 9:56 am on December 14, 2020: contributor

@jonatack

Maybe for mainnet tor v3 as well for bootstrapping connections in 0.21.0

tyi, long V3 addresses cant be fixed encode, in the old style manner, since ADDRv2 breaks the logic to hide them in ipv6, So i suggest to add them in chainparams, same effect since Tor skips anyway always the DNS logic and does connect to the seeder .onion anyway and does then the ADDR/ADDRv2. msg bootstrap .

i.e. vSeeds.emplace_back(“178.128.221.177”); vSeeds.emplace_back(“2a01:7c8:d005:390::5”); vSeeds.emplace_back(“ntv3mtqw5wt63red.onion:38333”); vSeeds.emplace_back(“signetsuperv3boostrapxxxxxxxxxxx.onion:38333”); // V3 onion addres

btw, that is even backwards and backport compatible since all old node software is capable to do V3 bootstrap over the ADDR message if the Tor stack on there crufts is updated and Tor V3 aware.

edit@saibato

concept ACK, better than nothing since not all have Tor enabled stacks.

in contrib/seeds/generate-seeds.py:8 in fae6558de4 outdated

4@@ -5,11 +5,12 @@
5 '''
6 Script to generate list of seed nodes for chainparams.cpp.
7 
8-This script expects two text files in the directory that is passed as an
9+This script expects text files in the directory that is passed as an

jonatack commented at 3:40 pm on December 14, 2020:

fa2e9d9573dacf nit, s/text files that is passed as an argument:/text files that are passed as arguments:/

MarcoFalke commented at 3:51 pm on December 14, 2020:

That’d be wrong. The directory is passed, not the text files.

jonatack commented at 4:02 pm on December 14, 2020:

Oh ok, I misunderstood on reading. Maybe: “expects to find text files in the directory that is passed as an argument:”

MarcoFalke commented at 4:12 pm on December 14, 2020:

Leaving doc rewording for a follow-up, which I am happy to review

jonatack commented at 3:47 pm on December 14, 2020: member

Tested and this appears to work.

 02020-12-14T15:45:25Z init message: Loading P2P addresses...
 12020-12-14T15:45:25Z ERROR: DeserializeFileDB: Failed to open file /home/jon/projects/bitcoin/bitcoin/datadir/signet/peers.dat
 22020-12-14T15:45:25Z Invalid or missing peers.dat; recreating
 32020-12-14T15:45:25Z tor: Got service ID t5acztv2shwvbbyfh6xktlgmryfhsw4ukloo2svlkhllfuwbzahtxlad, advertising service t5acztv2shwvbbyfh6xktlgmryfhsw4ukloo2svlkhllfuwbzahtxlad.onion:38333
 42020-12-14T15:45:25Z AddLocal(t5acztv2shwvbbyfh6xktlgmryfhsw4ukloo2svlkhllfuwbzahtxlad.onion:38333,4)
 52020-12-14T15:45:25Z ERROR: DeserializeFileDB: Failed to open file /home/jon/projects/bitcoin/bitcoin/datadir/signet/anchors.dat
 62020-12-14T15:45:25Z 0 block-relay-only anchors will be tried for connections.
 72020-12-14T15:45:25Z init message: Starting network threads...
 82020-12-14T15:45:25Z addcon thread start
 92020-12-14T15:45:25Z init message: Done loading
102020-12-14T15:45:25Z opencon thread start
112020-12-14T15:45:25Z dnsseed thread start
122020-12-14T15:45:25Z net thread start
132020-12-14T15:45:25Z msghand thread start
142020-12-14T15:45:25Z Loading addresses from DNS seed 178.128.221.177
152020-12-14T15:45:25Z Loading addresses from DNS seed 2a01:7c8:d005:390::5
162020-12-14T15:45:25Z Loading addresses from DNS seed ntv3mtqw5wt63red.onion:38333
172020-12-14T15:45:25Z 0 addresses found from DNS seeds
182020-12-14T15:45:25Z dnsseed thread exit
192020-12-14T15:45:27Z New outbound peer connected: version: 70016, blocks=15997, peer=0 (full-relay)
202020-12-14T15:46:26Z Adding fixed seed nodes as DNS doesn't seem to be available.
212020-12-14T15:46:26Z New outbound peer connected: version: 70016, blocks=15997, peer=1 (full-relay)
222020-12-14T15:46:27Z Synchronizing blockheaders, height: 2000 (~12.21%)

MarcoFalke added this to the milestone 0.21.1 on Dec 15, 2020

MarcoFalke removed this from the milestone 0.21.1 on Dec 15, 2020

MarcoFalke added this to the milestone 0.21.1 on Dec 15, 2020

MarcoFalke added the label Needs backport (0.21) on Dec 15, 2020

MarcoFalke commented at 6:55 am on December 15, 2020: member

Added to 0.21.1 milestone

fanquake requested review from kallewoof on Dec 21, 2020

fanquake requested review from ajtowns on Dec 21, 2020

kallewoof approved

kallewoof commented at 4:15 am on December 21, 2020: member

utACK fae6558de419b5825f11168f068058ea442fe131

laanwj commented at 5:23 pm on December 21, 2020: member

There’s no instructions in the release notes for updating this. I’m not sure this is necessary, but for example the testnet hardcoded seeds haven’t been updated in ages, for example, and it’s unclear how useful they still are.

MarcoFalke commented at 5:40 pm on December 21, 2020: member

The list was generated with getpeerinfo | grep addr. I am happy to add that to the release notes, but surely there are better ways to get a list in the future. Maybe someone will even run a dnsseeder.

ajtowns commented at 3:10 am on December 23, 2020: member

Looks okay to me

Sjors commented at 2:54 pm on December 30, 2020: member

What problem is this solving? More signet seeds just in case?

MarcoFalke commented at 12:21 pm on January 31, 2021: member

What problem is this solving? More signet seeds just in case?

fixed seeds are used as fallback seeds when the dns seeds can’t be queried for some reason

MarcoFalke removed the label Needs backport (0.21) on Feb 19, 2021

MarcoFalke removed this from the milestone 0.21.1 on Feb 19, 2021

contrib: Add seeds_signet.txt fa3d879618

scripted-diff: Run ./contrib/seeds/generate-seeds.py

-BEGIN VERIFY SCRIPT-
./contrib/seeds/generate-seeds.py ./contrib/seeds/ > src/chainparamsseeds.h
-END VERIFY SCRIPT-

fafd67ba24

chainparams: Add default fixed seeds for signet fae1a64a18

MarcoFalke force-pushed on Feb 19, 2021

MarcoFalke commented at 1:30 pm on February 19, 2021: member

Rebased to get rid of already merged hunks. No other changes.

in contrib/seeds/nodes_signet.txt:10 in fae1a64a18

 5+31.14.40.19:38333
 6+134.209.26.10:38333
 7+178.128.221.177:38333
 8+103.16.128.63:38333
 9+153.126.143.201:38333
10+192.241.163.142:38333

ajtowns commented at 4:48 am on February 26, 2021:

Only:

0    "address": "178.128.221.177",
1    "address": "103.16.128.63",
2    "address": "153.126.143.201",
3    "address": "192.241.163.142",

seem to still be present?

MarcoFalke commented at 9:08 am on February 26, 2021:

I think without a dns seeder or other software to track uptime, there will always be nodes in the list that are not reachable

ajtowns commented at 4:52 am on February 26, 2021: member

utACK fae1a64a18a72a760c56fde2f6795d56a535911f

I suppose running a dns seed and getting statistics from there for populating nodes_signet.txt is the way to get good values here.

MarcoFalke closed this on Apr 1, 2021

MarcoFalke deleted the branch on Apr 1, 2021

laanwj commented at 1:33 pm on April 1, 2021: member

Hadn’t really noticed this before it conflicted with the TorV3 one. Why close this?

MarcoFalke commented at 2:02 pm on April 1, 2021: member

Didn’t seem a lot of appetite and v3 for mainnet is more important than signet

DrahtBot locked this on Oct 31, 2022

chainparams: Add default fixed seeds for signet #20648

Conflicts