Designer fees when coin control is enabled #20652

pull gbizzotto wants to merge 1 commits into bitcoin:master from gbizzotto:master changing 6 files +343 −15

gbizzotto commented at 2:36 PM on December 14, 2020: none

This is an improvement over current UI fee selection. Current UI only allows kSat/kB fees, calculated over an approximation of the tx size. Some users may want to set a specific fee in satoshis, including zero, which isn't possible. This PR adds the UI items necessary for the user to set a specific fee.

Commit comment:

Fees can now be set in satoshis instead of kSat/kB only. Fees can now be set to zero satoshis. When switching to designer fee, or when inputs or outputs are changed, tx size is properly calculated (no guesswork). Fees, specified internally in sat/B, used to suffer alterations due to those approximations.

Designer fees when coin control is enabled:

Fees can now be set in satoshis instead of kSat/kB only.
Fees can now be set to zero satoshis.
When switching to designer fee, or when inputs or outputs are changed, tx size is properly calculated (no guesswork). Fees, specified internally in sat/B, used to suffer alterations due to those approximations.

2e71bc5cc4

gbizzotto renamed this:
~~Designer fees when coin control is enabled:~~
Designer fees when coin control is enabled
on Dec 14, 2020
DrahtBot added the label GUI on Dec 14, 2020
DrahtBot added the label Wallet on Dec 14, 2020
promag commented at 3:13 PM on December 14, 2020: member

GUI changes should be submitted in https://github.com/bitcoin-core/gui.
MarcoFalke commented at 3:40 PM on December 14, 2020: member

Also, make sure to run the test locally before submitting.
MarcoFalke closed this on Dec 14, 2020
DrahtBot locked this on Aug 16, 2022

Contributors

Labels