COMPACT_FILTERS should only be signalled when filter is in sync #20659

issue jonasschnelli opened this issue on December 15, 2020

jonasschnelli commented at 1:14 PM on December 15, 2020: contributor
I haven't tested this in detail but observed the following:
- peer is in sync (blockfilters disabled)
- stop peer
- start peer with -blockfilters=1 -peerblockfilters
- peer immediately sets service flag COMPACT_FILTERS
- filter has just started to sync
Probably not very crucial because AFAIK in case we get a NetMsgType::GETCFILTERS while not having the filter ready, we just don't response.
jonasschnelli added the label Bug on Dec 15, 2020
jonasschnelli added the label P2P on Dec 15, 2020
ysangkok commented at 4:36 PM on January 4, 2021: none

According to PR 19070 it seems this was done on purpose. So is it really a bug?
prusnak commented at 5:06 PM on February 8, 2021: contributor

@jonasschnelli @jnewbery can you please comment on what is the intended behaviour?
jnewbery commented at 5:23 PM on February 8, 2021: contributor

Yes, this was done on purpose, as discussed in #19070 and other places.
achow101 closed this on Oct 26, 2022
bitcoin locked this on Oct 26, 2023

Contributors

Labels