UI interface changes #2066

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:small_uiint_changes changing 6 files +11 −10

Diapolo commented at 12:56 PM on December 3, 2012: none
rework ThreadSafeAskFee() / askFee() functions
- remove unused parameter from ThreadSafeAskFee(), which also results in the removal of an orphan translation-string
remove unneeded flag from MSG_INFORMATION and fix an indentation
in src/qt/bitcoin.cpp:None in e66911cc20 outdated
```
  65 |      bool payFee = false;
  66 |  
  67 |      QMetaObject::invokeMethod(guiref, "askFee", GUIUtil::blockingGUIThreadConnection(),
  68 |                                 Q_ARG(qint64, nFeeRequired),
  69 | -                               Q_ARG(bool*, &payFee));
  70 | +                               Q_ARG(bool&, payFee));
```
laanwj commented at 1:10 PM on December 3, 2012:

Have you really tested that this works? I remember having quite some difficulties getting askFee to return a value over the thread boundary, and ended up with a pointer as the only option. AFAIK references are considered read-only by Qt.

Diapolo commented at 1:23 PM on December 3, 2012:

Yes, I sent a transaction (to myself in that test-case) and got asked the "do you want to pay ... bla bla" message, clicked Yes and got a tray-notification of that Tx. Can you try that code on Linux? Or do you want me to leave it a pointer?

Edit: Seems to be more sane to revert that changel as the Qt docs speak of Q_ARG() takes a type name and a const reference of that type; Q_RETURN_ARG() takes a type name and a non-const reference.
BitcoinPullTester commented at 1:17 PM on December 3, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e66911cc20c6bcd9200a39c6c3a4027b3102a8ce for binaries and test log.
remove unneeded flag from MSG_INFORMATION and fix an indentation 7f5a1b529b

rework ThreadSafeAskFee() / askFee() functions

- remove unused parameter from ThreadSafeAskFee(), which also results in
  the removal of an orphan translation-string

15d8ff2029

Diapolo commented at 8:37 PM on December 4, 2012: none

@laanwj I reverted that reference change, it's now the pointer again as we know that is working :).
BitcoinPullTester commented at 9:01 PM on December 4, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/15d8ff20294d20e6b11ec54450943eb7c5282ae0 for binaries and test log.
laanwj commented at 7:29 AM on December 6, 2012: member

ACK
laanwj referenced this in commit 25fd38090a on Dec 6, 2012
laanwj merged this on Dec 6, 2012
laanwj closed this on Dec 6, 2012
laudney referenced this in commit e2eee45d69 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester