Move signet onion seed from v2 to v3 #20660

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2020/12/signet-v3-onion changing 1 files +1 −1

Sjors commented at 1:16 PM on December 15, 2020: member

Since v0.21 hidden services use the longer v3 address format.

It may make sense to backport this to the v0.21 branch, although onion nodes can always use the non-onion seeds.
Move signet onion seed from v2 to v3 3e6657a14d
Sjors commented at 1:16 PM on December 15, 2020: member

cc @kallewoof
fanquake requested review from ajtowns on Dec 15, 2020
MarcoFalke commented at 1:33 PM on December 15, 2020: member

What is this patch doing? Does it somehow embed the v2 onion in a v3 onion? Does this depend on the operator upgrading the node?
DrahtBot added the label Validation on Dec 15, 2020
ajtowns commented at 2:38 PM on December 15, 2020: member

Might be smart to add the names of the seed maintainers in comments as per mainnet/testnet DNS seeds.
kallewoof commented at 3:01 PM on December 15, 2020: member

utACK @Sjors is the owner of the onion seed. I assume he switched it to using a v3 address.
MarcoFalke commented at 3:04 PM on December 15, 2020: member

Ah, I see. So the v2 one is probably not reachable anymore.

Concept ACK 3e6657a14d501c6315ab46ffe7d204684491c710
Saibato commented at 4:07 PM on December 15, 2020: contributor

Concept ACK

Although I would keep both v2 and v3 and skip v2 followup PR when v2 finally fades out. @Sjors tyi, in case the v2 v3 addresses are connected to a node of u , both addresses where down and unreachable over Tor, tested, short before i wrote these lines
4ldas approved

laanwj commented at 4:28 PM on December 15, 2020: member

I'm also unable to connect to the host

$ nc -v -x 127.0.0.1:9050  v7ajjeirttkbnt32wpy3c6w3emwnfr3fkla7hpxcfokr3ysd3kqtzmqd.onion 38333
…
nc: connection failed, SOCKSv5 error: General SOCKS server failure

ACK otherwise.

MarcoFalke removed the label Validation on Dec 15, 2020
MarcoFalke added the label P2P on Dec 15, 2020
Sjors commented at 4:49 PM on December 15, 2020: member

It's indeed my own seed node. Didn't want to doxx myself, but it's obvious from context anyway. Indeed the v2 is offline since afaik we don't support running both on the same node.

I'm having difficulty connecting to the service as well, but this is the onion its advertising.

For some reason when I restart it sometimes complains Cannot create socket for ntv3mtqw5wt63red.onion:38333: unsupported network, even though I'm running v0.21.0rc3 and ~/.bitcoin/signet/onion_v3_private_key exists. Actually, that's probably just the node trying to make an outbound connection to the v2 address seed.
Sjors commented at 4:58 PM on December 15, 2020: member

I guess it's just a bit flaky, it connects now: Connection to v7ajjeirttkbnt32wpy3c6w3emwnfr3fkla7hpxcfokr3ysd3kqtzmqd.onion 38333 port [tcp/*] succeeded!
Saibato commented at 5:00 PM on December 15, 2020: contributor

@Sjors tyi, @jb55 had a post on Twitter about onion balancing https://onionbalance.readthedocs.io/en/latest/ Maybe that is something u can use to make it more stable.

I had also with node the phenomena that old addresses linger in peer.dat and want to connect at random. A fresh peers,dat solved that.

Had a first thought that load balancing V3 in general for Bitcoin onion services could be a good idea. If there is interest, i could do a draft PR that integrates that into our torcontrol.cpp
laanwj commented at 8:33 PM on December 15, 2020: member

It connects for me now. ACK 3e6657a14d501c6315ab46ffe7d204684491c710
Saibato commented at 8:37 PM on December 15, 2020: contributor

tACK https://github.com/bitcoin/bitcoin/commit/3e6657a14d501c6315ab46ffe7d204684491c710 :+1:
laanwj merged this on Dec 15, 2020
laanwj closed this on Dec 15, 2020
sidhujag referenced this in commit 4bba5d9fad on Dec 15, 2020
MarcoFalke referenced this in commit 8273ea3b8d on Dec 16, 2020
MarcoFalke commented at 6:39 AM on December 16, 2020: member

Backported in #20669
DrahtBot locked this on Feb 15, 2022

Contributors

Review Requested
ajtowns

Labels

P2P