Allow setting I2P addresses #20662

pull lontivero wants to merge 1 commits into bitcoin:master from lontivero:set-i2p changing 3 files +81 −6
  1. lontivero commented at 5:39 PM on December 15, 2020: contributor

    This PR allows setting CNetAddr instances with I2P addresses by extending the existing method CNetAddr::SetSpecial.

    Currently the method SetSpecial can be used with Tor addresses only. After this PR the same method can be used to set traditional I2P base 32 address (those with suffix .b32.i2p)

  2. jonatack commented at 6:07 PM on December 15, 2020: member

    @lontivero Have you had a look at #20254? It may be a good idea to share ideas/review each other.

  3. laanwj added the label P2P on Dec 15, 2020
  4. lontivero commented at 6:24 PM on December 15, 2020: contributor

    @jonatack i wasn't aware of #20254. I will close this one then. Thank you.

  5. lontivero closed this on Dec 15, 2020

  6. jonatack commented at 6:36 PM on December 15, 2020: member

    @lontivero Oh, to be clear I wasn't suggesting to close it but to review the other one and help each other.

  7. lontivero reopened this on Dec 15, 2020

  8. jonatack commented at 6:49 PM on December 15, 2020: member

    Saw your review of #20254 -- that's great. Hope i2p support can move forward.

  9. lontivero force-pushed on Dec 15, 2020
  10. Allow setting I2P addresses 0202177f27
  11. lontivero force-pushed on Dec 16, 2020
  12. vasild commented at 1:06 PM on December 17, 2020: member

    This functionality (with very similar diff) is included in #20685 as commit net: extend CNetAddr::SetSpecial() to support I2P.

    I think it makes very little impact on its own - it makes Lookup() support I2P addresses, which in turn makes it possible to manually connect to an I2P node by using -proxy=i2p_socks5_proxy:port -addnode=i2p_address.b32.i2p:port.

    But using the socks5 proxy in I2P usually means only being able to reach I2P peers and is discouraged.

  13. lontivero commented at 3:11 PM on December 17, 2020: contributor

    #20685 already contains these changes.

  14. lontivero closed this on Dec 17, 2020

  15. DrahtBot locked this on Feb 15, 2022
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 00:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me