test: Fix restart node race #20683

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-testNodeStart changing 2 files +5 −3
  1. MarcoFalke commented at 12:24 pm on December 17, 2020: member

    It is not allowed to start a node before it has been fully stopped. Otherwise it could lead to intermittent issues due to access issues (e.g. cookie file https://cirrus-ci.com/task/6409665024098304?command=ci#L4793)

    Fix that by waiting for the node to fully stop.

  2. DrahtBot added the label Tests on Dec 17, 2020
  3. test: Fix restart node race fab46b34f4
  4. MarcoFalke force-pushed on Dec 17, 2020
  5. DrahtBot commented at 8:17 pm on December 17, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19983 (Drop some TSan suppressions by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. laanwj commented at 7:19 pm on December 21, 2020: member
    code review ACK fab46b34f4b13abbb0af276c3fb548f25ccc28bd
  7. laanwj merged this on Dec 21, 2020
  8. laanwj closed this on Dec 21, 2020

  9. MarcoFalke deleted the branch on Dec 21, 2020
  10. sidhujag referenced this in commit 936706d809 on Dec 21, 2020
  11. Fabcien referenced this in commit b1a28d9a77 on Jan 12, 2021
  12. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me