test: Add race:SendZmqMessage tsan suppression #20748

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-ciSuppZmq changing 1 files +11 −0

MarcoFalke commented at 6:17 PM on December 22, 2020: member

Add suppression for race:SendZmqMessage, which isn't covered by the existing zmq::* suppression

Fixes #20618
MarcoFalke force-pushed on Dec 22, 2020

in test/sanitizer_suppressions/tsan:28 in fa1d34993f outdated

  24 | @@ -25,8 +25,8 @@ race:WalletBatch::WriteHDChain
  25 |  race:BerkeleyBatch
  26 |  race:BerkeleyDatabase
  27 |  race:DatabaseBatch
  28 | +race:SendZmqMessage

hebasto commented at 6:38 PM on December 22, 2020:

Looking at the log, I'd suggest to be more specific:

race:CZMQAbstractPublishNotifier::SendZmqMessage

MarcoFalke commented at 7:13 PM on December 22, 2020:

Thanks, done

hebasto approved
hebasto commented at 6:40 PM on December 22, 2020: member

ACK fa1d34993f345b2e799baf53174dd258d91f4db1, I have reviewed the code and it looks OK, I agree it can be merged.
DrahtBot added the label Tests on Dec 22, 2020
MarcoFalke force-pushed on Dec 22, 2020
hebasto approved
hebasto commented at 7:17 PM on December 22, 2020: member

re-ACK fa867daff99bbb2fa2e511f18cac7138e0bd5145
test: Add race:SendZmqMessage tsan suppression fa957f8dc9
MarcoFalke force-pushed on Dec 22, 2020
MarcoFalke commented at 9:00 PM on December 22, 2020: member

restored the zmq::* one because it was working and needed
hebasto commented at 10:29 AM on December 23, 2020: member
restored the zmq::* one because it was working and needed

Some related discussions:
- https://github.com/zeromq/libzmq/issues/3919
- https://github.com/zeromq/libzmq/pull/3929
From the log it seems possible to replace race:zmq::* with
```
race:zmq::encoder_base_t
race:zmq::ypipe_t
```
And one more question: if race:zmq::* does almost all zmq-related job, what is the reason to have race:libzmq?
hebasto commented at 10:30 AM on December 23, 2020: member

re-ACK fa957f8dc9990e4479e4d2af46a63ceae89cd39b, as my previous comment is not directly related to this pull changes.
MarcoFalke commented at 11:31 AM on December 23, 2020: member

And one more question: if race:zmq::* does almost all zmq-related job, what is the reason to have race:libzmq?

Maybe it was needed when we still used the libzmq3-dev apt package, and not depends?
MarcoFalke merged this on Dec 23, 2020
MarcoFalke closed this on Dec 23, 2020
MarcoFalke deleted the branch on Dec 23, 2020
sidhujag referenced this in commit e61f260ecb on Dec 23, 2020
Fabcien referenced this in commit 38f199ef7c on Oct 13, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

MarcoFalke

hebasto

Labels

Tests

Linked (view graph)

#20618 Data race in interface_zmq.py