[fuzzing] Use subprocess.Popen call directly, remove use of thread pool. #20751

1. 
   pstratem commented at 4:12 am on December 23, 2020: contributor

   This removes the threadpools from test/fuzz/test_runner.py.

   Each thread just spawns a subprocess, there’s no reason to have both a thread and subprocess.

2. fanquake added the label Tests on Dec 23, 2020
3. pstratem force-pushed on Dec 23, 2020
4. Use subprocess.Popen call directly, remove use of thread pool. ea36284d17
5. pstratem force-pushed on Dec 23, 2020
6. 
   MarcoFalke commented at 7:24 am on December 23, 2020: member

   This needs a bit more code, so absent any performance speedup, I’d prefer the previous version. My assumption was that the fuzzing happens in the subprocess, so any python GIL “deadlocks” in the thread pool won’t have any performance effect on the subprocess itself. I might be wrong, though.
7. pstratem marked this as a draft on Dec 23, 2020
8. 
   DrahtBot commented at 11:19 am on December 24, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20759 (doc: [test] Remove outdated comment in fuzz runner by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   DrahtBot commented at 11:18 pm on December 13, 2021: member

   🐙 This pull request conflicts with the target branch and needs rebase.

   Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

10. DrahtBot added the label Needs rebase on Dec 13, 2021
11. 
    DrahtBot commented at 1:06 pm on March 21, 2022: member

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
12. MarcoFalke closed this on Mar 22, 2022

    ---

13. DrahtBot locked this on Mar 22, 2023

Contributors
pstratem MarcoFalke DrahtBot

Labels
Tests Needs rebase