[doc] Add missing field (permissions) to the getpeerinfo help #20756

1. 
   amitiuttarwar commented at 7:48 pm on December 23, 2020: contributor

   This field was previously being returned, but missing from the RPCHelpMan. This PR uses the existing NET_PERMISSIONS_DOC to inform RPC users about this field.

    0   "permissions" : [                 (json array) Any special permissions that have been granted to this peer
    1      "str",                          (string) bloomfilter (allow requesting BIP37 filtered blocks and transactions),
    2                                      noban (do not ban for misbehavior; implies download),
    3                                      forcerelay (relay transactions that are already in the mempool; implies relay),
    4                                      relay (relay even in -blocksonly mode, and unlimited transaction announcements),
    5                                      mempool (allow requesting BIP35 mempool contents),
    6                                      download (allow getheaders during IBD, no disconnect after maxuploadtarget limit),
    7                                      addr (responses to GETADDR avoid hitting the cache and contain random records with the most up-to-date info).
    8
    9      ...
   10    ],
   

2. [doc] Add permissions to the getpeerinfo help.

   This field was already being returned, but the RPCHelpMan did not indicate
   this. So, this PR updates the help text to match.

   667d203687
3. 
   DrahtBot commented at 9:39 pm on December 23, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20755 ([rpc] Remove deprecated fields from getpeerinfo by amitiuttarwar)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label RPC/REST/ZMQ on Dec 23, 2020
5. 
   Sjors commented at 11:42 am on December 24, 2020: member

   tACK 667d203687708390bc0f43f2dd3f4ab427b88338
6. 
   MarcoFalke commented at 11:47 am on December 24, 2020: member

   Btw, this will be caught by #20459 (step 1/2) eventually
7. MarcoFalke merged this on Dec 26, 2020
8. MarcoFalke closed this on Dec 26, 2020

   ---

9. MarcoFalke referenced this in commit b1c0f97483 on Dec 26, 2020
10. MarcoFalke referenced this in commit df58d2b9bf on Dec 26, 2020
11. sidhujag referenced this in commit 06db58b830 on Dec 27, 2020
12. MarcoFalke referenced this in commit 9457f1502e on Jan 4, 2021
13. MarcoFalke referenced this in commit 19bcf17848 on Jan 5, 2021
14. jaysonmald35 approved
15. DrahtBot locked this on Sep 2, 2022

Contributors
amitiuttarwar DrahtBot Sjors MarcoFalke jaysonmald35

Labels
RPC/REST/ZMQ