net, rpc, gui: add network to peers window and peer details #20779

1. 
   jonatack commented at 2:03 pm on December 27, 2020: member

   This is a migration of https://github.com/bitcoin-core/gui/pull/162 to this repo. It adds a network column to the Peers window, adds the network to the peer details, and renames two peers column headers from NodeId and Node/Service to Peer Id and Address. The initial version of the pull only changed gui code; however, the first commit now touches code in net.{h, cpp} and rpc/net.cpp. Please see the original pull for the review up to this point, including an ACK by hebasto.

   

2. net, rpc: change CNodeStats::m_network from string to Network 598223beda
3. gui: create GUIUtil::NetworkToQString() utility function 174b681d10
4. gui: fix broken doxygen formatting in src/qt/guiutil.h e25c42f7c7
5. gui: add network column in peers tab/window 3fef5a0291
6. gui: rename peer tab column headers, initialize in .h 5d8b65f8ae
7. gui: display network in peer details 44449efd63
8. 
   DrahtBot commented at 2:30 pm on December 27, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20778 (net, p2p, gui: replace direction with connection type in gui peer details window by jonatack)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. DrahtBot added the label GUI on Dec 27, 2020
10. DrahtBot added the label P2P on Dec 27, 2020
11. DrahtBot added the label RPC/REST/ZMQ on Dec 27, 2020
12. 
    Sjors commented at 12:06 pm on December 28, 2020: member

    Rather than moving the entire PR over, why not limit this PR to the non-GUI changes you need?
13. 
    jonatack commented at 12:45 pm on December 28, 2020: member

    The changes make more sense together (I suspect no one would review the first commit on its own) and it’s fewer pulls to maintain and review.
14. 
    MarcoFalke commented at 2:53 pm on December 28, 2020: member

    Tend to agree with @sjors . Most reviewers in this repo can’t review the gui changes and a simple RPC refactor can be standalone. Linking to the gui repo for motivation should be sufficient, if it is not motivated by itself enough.
15. 
    jonatack commented at 2:59 pm on December 28, 2020: member

    This pull follows the guidelines in CONTRIBUTING.md about tranversal changes. It is the second pull I have opened for this one change; the first pull originally touched only GUI code, but reviewers asked for transversal changes. Now people are asking for more pulls, with one in one repo gated by the other in the other repo. I understand the reasons for splitting the repos, but it is fair to say those reasons did not include complicating contributions in this way to the GUI.

    Up for grabs.

16. jonatack closed this on Dec 28, 2020

    ---

17. DrahtBot locked this on Feb 15, 2022

Contributors
jonatack DrahtBot Sjors MarcoFalke

Labels
GUI RPC/REST/ZMQ P2P