I spent too long to figure out I was putting mainnet addresses to regtest node, errors weren't helpful at getaddressinfo and validateaddress.
Seems like a good first issue to augment the error messages when prefix/hrp don't match current network.
hmm, not a bug, feature request.
<!-- Needs the label "good first issue" assigned manually before or after opening -->
<!-- A good first issue is an uncontroversial issue, that has a relatively unique and obvious solution -->
<!-- Motivate the issue and explain the solution briefly -->
For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.
This may be useful for whoever picks this up. https://bitcoin.stackexchange.com/questions/100508/can-you-break-down-what-data-is-encoded-into-a-bech32-address
Should this be done for all addresses (including pre bech32) or just bech32?
<pre> getaddressinfo "bc1qjjrlgl28uqjtv0at2n3pfv3qtuvrm85vr0am5v" Invalid address (code -5) </pre>
<pre> validateaddress "bc1qjjrlgl28uqjtv0at2n3pfv3qtuvrm85vr0am5v" { "isvalid": false } </pre>
@instagibbs I get these results for a 'mainnet' address used on testnet. What would you like to see in the new error messages? Address type mentioned in error based on prefix/hrp and network used?
Yeah ideally the message would have appended the detail "wrong network" or something like that.
On Fri, Jan 1, 2021, 4:54 AM Prayank notifications@github.com wrote:
getaddressinfo "bc1qjjrlgl28uqjtv0at2n3pfv3qtuvrm85vr0am5v"
Invalid address (code -5)
validateaddress "bc1qjjrlgl28uqjtv0at2n3pfv3qtuvrm85vr0am5v"
{ "isvalid": false }
@instagibbs https://github.com/instagibbs I get these results for a 'mainnet' address used on testnet. What would you like to see in the new error messages? Address type mentioned in error based on prefix/hrp?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/20809#issuecomment-753140435, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMAFU66AFVYVQNFVB2BVTTSXTQJFANCNFSM4VO6Z7BQ .
Hello! I would be interested in working on this feature as it seems a good way for a first contribution. I've already managed to add an additional property called "error_msg" inside "validateaddress" in case the address is not valid and set it when the address is invalid.
As for testing, I suppose I should add a functional test for this feature am I right?
@eilx2 Yes, check for assert_raises_rpc_error in the functional suite for inspiration on how to check these string returns.
When you open the PR feel free to tag me :+1:
