In 0.21, we added unbroadcast txids to mempool.dat (#18038). When users upgraded from 0.21 to 0.22, this would throw a misleading "failed to deserialize mempool data" error even though everything actually loaded properly. So, commit 9c8a55d added a try-block to prevent throwing the error. After upgrading to 0.22, this exception handling is no longer useful, so now we can remove it.
[mempool] Remove unnecessary try-block #20854
pull amitiuttarwar wants to merge 1 commits into bitcoin:master from amitiuttarwar:2021-01-load-mempool-cleanup changing 1 files +2 −8-
amitiuttarwar commented at 8:47 PM on January 4, 2021: contributor
-
7ff05358a9
[mempool] Remove error suppression on upgrade
In 0.21, we added unbroadcast txids to mempool.dat. Commit 9c8a55d added a try-block to prevent throwing a "failed to deserialize mempool data" error when a user upgrades from 0.21 to 0.22. This exception handling is no longer useful, so now we can remove it.
- DrahtBot added the label Validation on Jan 4, 2021
-
amitiuttarwar commented at 11:58 PM on January 4, 2021: contributor
from a quick look, the test causing CI to be red looks like a failure in
interface_zmq.pyaround the sequence number of the coinbase tx in a block.seems unrelated to these changes.
-
MarcoFalke commented at 9:46 AM on January 5, 2021: member
review ACK 7ff05358a96f49ae6b7eb265ce301748bfde30a8
nice cleanup. ci failure is known and can be ignored
- MarcoFalke removed the label Validation on Jan 5, 2021
- MarcoFalke added the label Mempool on Jan 5, 2021
- theStack approved
-
theStack commented at 10:34 AM on January 5, 2021: member
Code review ACK 7ff05358a96f49ae6b7eb265ce301748bfde30a8
- MarcoFalke merged this on Jan 5, 2021
- MarcoFalke closed this on Jan 5, 2021
- sidhujag referenced this in commit 80b94f53e0 on Jan 5, 2021
- Fabcien referenced this in commit 73f6a97f26 on Jul 20, 2022
- DrahtBot locked this on Aug 16, 2022
