test: update documentation in feature_csv_activation.py #20857

pull PiRK wants to merge 1 commits into bitcoin:master from PiRK:patch-1 changing 1 files +2 −2

PiRK commented at 10:09 AM on January 5, 2021: contributor

These changes in the test documentation reflect the changes introduced in #17921.
fanquake added the label Tests on Jan 5, 2021
fanquake renamed this:
~~update docstring in feature_csv_activation.py to account for 17921~~
test: update documentation in feature_csv_activation.py
on Apr 9, 2021
fanquake requested review from theStack on Apr 9, 2021
theStack approved
theStack commented at 6:29 PM on April 17, 2021: member

ACK e2a206329fca3158e25e8a7b279e92ec8763a04b Verified that the numbers match, also the grammar/stylistic changes LGTM.

update docstring in feature_csv_activation.py

These changes in the test documentation reflect the changes introduced in #17921

9053b88b1c

in test/functional/feature_csv_activation.py:13 in e2a206329f outdated

   8 | @@ -9,8 +9,8 @@
   9 |  BIP 112 - CHECKSEQUENCEVERIFY
  10 |  BIP 113 - MedianTimePast semantics for nLockTime
  11 |  
  12 | -mine 82 blocks whose coinbases will be used to generate inputs for our tests
  13 | -mine 345 blocks and seed block chain with the 82 inputs will use for our tests at height 427
  14 | +mine 83 blocks whose coinbases will be used to generate inputs for our tests
  15 | +mine 344 blocks and seed blockchain with the 83 inputs used for our tests at height 427

jonatack commented at 6:41 PM on April 17, 2021:

nit, I think there's no need to change "block chain"; see https://github.com/bitcoinops/bitcoinops.github.io/blob/master/STYLE.md#compound-words

PiRK commented at 8:06 PM on April 18, 2021:

I reverted this change. Thanks for the link.

PiRK force-pushed on Apr 18, 2021
MarcoFalke commented at 7:47 AM on April 19, 2021: member

review ACK 9053b88

checked that COINBASE_BLOCK_COUNT is 83. didn't check the other constant
MarcoFalke merged this on Apr 19, 2021
MarcoFalke closed this on Apr 19, 2021
sidhujag referenced this in commit 91366bf683 on Apr 19, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#17921 test: test OP_CSV empty stack fail in feature_csv_activation.py