Use callers cwd if path is not fully qualified and connecting to 127.0.0.1.
Use callers cwd for backupwallet if 127.0.0.1 #209
pull jrmithdobbs wants to merge 1 commits into bitcoin:master from jrmithdobbs:fix_backupwallet_path changing 1 files +7 −0-
jrmithdobbs commented at 9:59 AM on May 9, 2011: contributor
-
Use callers cwd if path is not fully qualified and connecting to 127.0.0.1. 55c7838594
-
luke-jr commented at 12:46 AM on December 25, 2011: member
Perhaps there's a way to compare the two systems' hostnames?
-
laanwj commented at 12:20 PM on December 28, 2011: member
@midnightmagic: But if the host is remote/tunneled, wouldn't it make sense to use a fully qualified path in the first place?
I think, in general, with this API you always want to send a fully qualified path to make sure the backup ends up in the right place.
Maybe the API should be similarly changed to reject non-fully qualified paths, to prevent (extremely sensitive) backups from being written to places the user doesn't expect them.
-
sipa commented at 10:49 PM on February 19, 2012: member
What about retuning a serialized version of the snapshot of wallet.dat through RPC, and let the RPC client store it somewhere?
-
luke-jr commented at 10:52 PM on February 19, 2012: member
That opens up a whole new level of security issues.
-
laanwj commented at 6:51 PM on February 20, 2012: member
Would it make a large difference, security-wise? You can already request all the private keys through RPC isn't it?
-
luke-jr commented at 8:16 PM on February 20, 2012: member
Forgot that was merged. Nevermind.
-
sipa commented at 5:10 PM on April 8, 2012: member
Sending more than a few megabytes over RPC becomes a problem though - and there are certainly wallets that large out there.
-
laanwj commented at 7:04 PM on April 12, 2012: member
Agreed.
What are we going to do here?
-
- jgarzik closed this on May 8, 2012
- zathras-crypto referenced this in commit 605df0e485 on Nov 27, 2014
- dexX7 referenced this in commit f6a9ede6aa on Aug 31, 2015
- deadalnix referenced this in commit 1e2e805fc8 on Jan 6, 2017
- lateminer referenced this in commit a730554c82 on Dec 9, 2017
- classesjack referenced this in commit 6e639d6e6d on Jan 2, 2018
- attilaaf referenced this in commit 4d1cd0783b on Jan 13, 2020
- MarcoFalke referenced this in commit 5e4a3ca2f4 on Feb 22, 2021
- rajarshimaitra referenced this in commit e26eeb29ea on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels