OptionsModel now has MapPortUPnP=false if UPNP is not supported #2094

pull al42and wants to merge 3 commits into bitcoin:master from al42and:upstream changing 2 files +368 −168

al42and commented at 7:51 AM on December 12, 2012: contributor

When compiled with "USE_UPNP=-", in "Options/Network" tab the "Map port using UPNP" checkbox is set up and disabled, which creates the impression that UPNP is always on.

This patch makes OptionModel to always return false is UPNP is disabled, which solves this checkbox problem and, IMHO, is much more intuitive behaviour overall.
OptionsModel now has MapPortUPnP=false if UPNP is not supported 333df36116
BitcoinPullTester commented at 8:17 AM on December 12, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/333df361162c6440257edf59a907d5d5e8b91e49 for binaries and test log.
Update russian transaltion to latest git 27659e3de6
Merge branch 'upstream' of github.com:al42and/bitcoin into upstream 8672bd3ba2
BitcoinPullTester commented at 9:00 AM on December 12, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8672bd3ba22664c8ee061f2876c174120bf27f56 for binaries and test log.
al42and closed this on Dec 12, 2012
DrahtBot locked this on Sep 8, 2021

Contributors