OptionsModel now has MapPortUPnP=false if UPNP is not supported #2095

pull al42and wants to merge 1 commits into bitcoin:master from al42and:upnp changing 1 files +4 −0

al42and commented at 9:23 AM on December 12, 2012: contributor

When compiled with USE_UPNP=-, in "Options/Network" tab the "Map port using UPNP" checkbox is set up and disabled, which creates the impression that UPnP is always on.

This patch makes OptionModel to always return false if UPnP is disabled, which solves this checkbox problem and, IMHO, is much more intuitive behaviour overall. Please review.
OptionsModel now has MapPortUPnP=false if UPNP is not supported 6a3aef39e7
BitcoinPullTester commented at 9:43 AM on December 12, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6a3aef39e70e6da81cbd2484c1721d44f9b02d9a for binaries and test log.
laanwj commented at 10:08 AM on December 12, 2012: member

Yes good idea, ACK
Diapolo commented at 2:10 PM on December 12, 2012: none

Yeah, good idea, ACK.
gavinandresen referenced this in commit 278a09a6c6 on Dec 12, 2012
gavinandresen merged this on Dec 12, 2012
gavinandresen closed this on Dec 12, 2012
laudney referenced this in commit e13b67f0ec on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors