doc: Update tor.md for notes on how to preserve v2 urls (with a not recommended note) #20957

pull nolim1t wants to merge 1 commits into bitcoin:master from nolim1t:tor-controlport-docs changing 1 files +6 −0
  1. nolim1t commented at 9:23 am on January 18, 2021: none

    Add the the text from the release notes to the actual documentation docs/tor.md to document how users can preserve their old address.

    Just in case users would like for some reason to preserve their existing v2 address with a not recommended text.

  2. fanquake added the label Docs on Jan 18, 2021
  3. jonatack commented at 9:34 am on January 18, 2021: member
    Thanks @nolim1t. Unless this change is backported to 0.21.1, by the time 22.0 (the next release) is out tor v2 will be EOL, so maybe the existing release notes are enough. It may be good to squash your commits down to one when you are finished.
  4. lehuuhieu7777 approved
  5. Add to the documentation on retaining v2 .onions with a not advised flag 7e08a1b570
  6. nolim1t force-pushed on Jan 18, 2021
  7. nolim1t commented at 10:33 am on January 18, 2021: none

    Thanks @nolim1t. Unless this change is backported to 0.21.1, by the time 22.0 (the next release) is out tor v2 will be EOL, so maybe the existing release notes are enough. It may be good to squash your commits down to one when you are finished.

    Squashed into one. Yep I recognize that it may be deprecated too, hence not recommended mention

  8. laanwj commented at 2:58 pm on January 18, 2021: member
    We’re on the trailing edge of TorV2 support here, and this is a really hacky workaround. I too think that the mention in the release notes is enough. No strong objection though.
  9. jarolrod commented at 4:22 am on January 24, 2021: member
    Concept 0 on this, I think there’s no need to mention this as it is will be mandatory to migrate to torv3 since support for v2 addresses will be disabled on the network, see Tor Deprecation Timeline
  10. DrahtBot commented at 4:23 pm on January 26, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20757 (doc: tor.md and -onlynet help updates by jonatack)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  11. DrahtBot commented at 2:18 pm on January 27, 2021: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  12. DrahtBot added the label Needs rebase on Jan 27, 2021
  13. laanwj commented at 2:23 pm on January 27, 2021: member
    I’m going to close this, sorry. Everyone is at most ~0 on this, which makes it unlikely that this will be merged. It doesn’t seem worth the hassle to rebase .
  14. laanwj closed this on Jan 27, 2021

  15. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me