The conditional that checks if docker needs to be installed has the side effect of triggering the default lxc branch in case docker comes preinstalled. This is clearly not intentional.
contrib: Fix docker args conditional in gitian-build #21004
pull setpill wants to merge 1 commits into bitcoin:master from setpill:improve-gitian-build-py changing 1 files +10 −9-
setpill commented at 5:42 PM on January 25, 2021: contributor
-
Fix docker args conditional 624091b7b9
- DrahtBot added the label Build system on Jan 25, 2021
- DrahtBot added the label Scripts and tools on Jan 25, 2021
-
laanwj commented at 7:24 PM on January 25, 2021: member
Code review ACK 624091b7b97ed371900ca7c68f3e2929954e3464
- MarcoFalke renamed this:
Fix docker args conditional
contrib: Fix docker args conditional in gitian-build
on Jan 25, 2021 - MarcoFalke removed the label Build system on Jan 25, 2021
- fanquake requested review from hebasto on Jan 26, 2021
- theStack approved
-
theStack commented at 4:25 PM on January 28, 2021: member
Code review ACK 624091b7b97ed371900ca7c68f3e2929954e3464 As someone who uses gitian-build with
--docker, I remember wondering why .the setup procedure installed lxc (obviously I had docker already installed, so theelse-path was triggered). Thanks for fixing! - MarcoFalke merged this on Jan 28, 2021
- MarcoFalke closed this on Jan 28, 2021
- sidhujag referenced this in commit 6597107c89 on Jan 28, 2021
- UdjinM6 referenced this in commit edcb8fd08e on Sep 2, 2021
- UdjinM6 referenced this in commit f0cfb10231 on Sep 2, 2021
- DrahtBot locked this on Aug 18, 2022
