Add release notes for listdescriptors RPC #21049

pull S3RK wants to merge 1 commits into bitcoin:master from S3RK:patch-1 changing 1 files +4 −0

S3RK commented at 8:09 AM on February 1, 2021: member

Original PR is #20226
S3RK commented at 8:09 AM on February 1, 2021: member

cc @jonatack
fanquake added the label Docs on Feb 1, 2021
laanwj commented at 8:53 AM on February 1, 2021: member

ACK 1ac5bc03c6d385cdc62e1d3560dfbcf3fed4d3f5

in doc/release-notes.md:96 in 1ac5bc03c6 outdated

  92 | @@ -93,6 +93,10 @@ Tools and Utilities
  93 |  Wallet
  94 |  ------
  95 |  
  96 | +- New `listdescriptors` RPC is available to inspect contents of a descriptor-enabled wallet.

jonatack commented at 9:04 PM on February 1, 2021:

- A new `listdescriptors` RPC is available to inspect the contents of descriptor-enabled wallets.

in doc/release-notes.md:98 in 1ac5bc03c6 outdated

  92 | @@ -93,6 +93,10 @@ Tools and Utilities
  93 |  Wallet
  94 |  ------
  95 |  
  96 | +- New `listdescriptors` RPC is available to inspect contents of a descriptor-enabled wallet.
  97 | +  The RPC returns public versions of all imported descriptors, including their timestamp and flags.
  98 | +  For ranged descriptor it also returns range boundaries and the next index to generate addresses from.

jonatack commented at 9:04 PM on February 1, 2021:

  For ranged descriptors, it also returns the range boundaries and the next index to generate addresses from. (#20226)

jonatack commented at 9:05 PM on February 1, 2021: member

A few minor suggestions below. Do you plan to address #20226 (review)?
Add release notes for listdescriptors RPC
Original PR is #20226
51f3752fbe
S3RK force-pushed on Feb 2, 2021
S3RK commented at 8:38 AM on February 2, 2021: member

I tried so hard and got so far But in the end there were still a few minor suggestions...

Thanks jonatack, hope one day I'll get my articles right 😄

Do you plan to address #20226 (comment)?

Done — #21063
jonatack commented at 2:28 PM on February 2, 2021: member

ACK 51f3752

Thanks for updating. No worries :)
jonasschnelli approved
jonasschnelli commented at 7:33 AM on February 4, 2021: contributor

ACK 51f3752fbeee09d025db33e154bb2efff9e20837
MarcoFalke merged this on Feb 4, 2021
MarcoFalke closed this on Feb 4, 2021
sidhujag referenced this in commit 0abaa33f63 on Feb 4, 2021
S3RK deleted the branch on Mar 1, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#20226 wallet, rpc: add listdescriptors command