Follow-ups to PR 19509 - Message Capture #21079

issue jnewbery opened this issue on February 4, 2021

jnewbery commented at 11:42 AM on February 4, 2021: member
This issue tracks follow-up actions from #19509
- Use 1 file = 1 session #19509 (comment)
- Update message type checking in p2p_message_capture.py: #19509 (review)
- Remove MakeUCharSpan #19509 (review)
- Add RPC to enable/disable message capture per peer
- Vulture warning about discarded value https://github.com/bitcoin/bitcoin/pull/19509/files#r571454691
jnewbery added the label Bug on Feb 4, 2021
jnewbery removed the label Bug on Feb 4, 2021
jnewbery added the label Feature on Feb 4, 2021
jnewbery commented at 11:43 AM on February 4, 2021: member

@troygiorshev I think I've captured all the follow-ups here. Are you planning on implementing these or should I mark as up for grabs?
jnewbery renamed this:
~~Follow-ups to PR 19509~~
Follow-ups to PR 19509 - Message Capture
on Feb 4, 2021
flack commented at 6:31 PM on February 7, 2021: contributor

see also: https://github.com/bitcoin/bitcoin/pull/19509/files#r571454691
jnewbery commented at 7:26 PM on February 7, 2021: member

see also: #19509 (files)

added
jnewbery closed this on Jun 20, 2022
DrahtBot locked this on Jun 20, 2023

Contributors

Labels