This is useful to see mismatched values when a check fails as specified in the Boost documentation.
This PR would make #20744 PR's diff smaller by a bit.
test: Change BOOST_CHECK to BOOST_CHECK_EQUAL for paths #21125
pull kiminuo wants to merge 1 commits into bitcoin:master from kiminuo:feature/boost-equal changing 2 files +8 −8-
kiminuo commented at 2:05 PM on February 9, 2021: contributor
-
059e8ccc1e
Change BOOST_CHECK to BOOST_CHECK_EQUAL to see mismatched values when a check fails.
See https://www.boost.org/doc/libs/1_71_0/libs/test/doc/html/boost_test/utf_reference/testing_tool_ref/assertion_boost_level_eq.html
- kiminuo renamed this:
test: Change BOOST_CHECK to BOOST_CHECK_EQUAL
test: Change BOOST_CHECK to BOOST_CHECK_EQUAL for paths
on Feb 9, 2021 -
MarcoFalke commented at 2:08 PM on February 9, 2021: member
review ACK 059e8ccc1eba6cd92f4c434325cb56b0533eb744
- fanquake added the label Tests on Feb 9, 2021
- theStack approved
-
theStack commented at 5:25 PM on February 9, 2021: member
Code Review ACK 059e8ccc1eba6cd92f4c434325cb56b0533eb744
Note that this is just the tip of the iceberg, there are hundreds of other instances where the same replacement could be done:
$ git grep "BOOST_CHECK(.*==.*)" | wc -l 917(of course, this also includes some false-positives)
- MarcoFalke merged this on Feb 10, 2021
- MarcoFalke closed this on Feb 10, 2021
- kiminuo deleted the branch on Feb 10, 2021
- sidhujag referenced this in commit 05c420bf56 on Feb 11, 2021
- PastaPastaPasta referenced this in commit 60b7b932e2 on Nov 1, 2021
- PastaPastaPasta referenced this in commit 0627ea1d4c on Nov 1, 2021
- PastaPastaPasta referenced this in commit 2d30d33811 on Nov 3, 2021
- pravblockc referenced this in commit 2da267b8c3 on Nov 18, 2021
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels