test: Use proper mocktime for uptime #21164

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2102-mockTimeInit changing 5 files +33 −26

MarcoFalke commented at 5:16 PM on February 12, 2021: member

Fixes https://github.com/bitcoin/bitcoin/pull/19884/files#r575336503

Set startup time for uptime at the beginning of AppInitParameterInteraction

Stop initializing nStartupTime to system time. This is needed for many
things:

* It is making it harder to assert that fuzzing only uses mocked time.
* When using mocked time in the program arguments, nStartupTime will be
  incorrectly initialized to system time.

facb959747

test: Use mocktime to speed up test_seed_peers fa1025d338
MarcoFalke added the label Tests on Feb 12, 2021
jonatack commented at 5:34 PM on February 12, 2021: member

Concept ACK, first skim of code looks pretty good.
dhruv commented at 5:41 PM on February 12, 2021: member

Whoops, I think we crossed wires and I created #21165 - happy to close it if you prefer. I was able to accomplish the faster test without any C++ changes so might be easier to review.
MarcoFalke commented at 7:30 PM on February 12, 2021: member

Ah, thanks. Closing this one.
MarcoFalke closed this on Feb 12, 2021
MarcoFalke deleted the branch on Feb 12, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#19884 p2p: No delay in adding fixed seeds if -dnsseed=0 and peers.dat is empty