test: Use mocktime in test_seed_peers #21165

pull dhruv wants to merge 2 commits into bitcoin:master from dhruv:fix-for-19884 changing 2 files +15 −14
  1. dhruv commented at 5:39 pm on February 12, 2021: member

    The test now takes less than 5 seconds instead of more than 2 minutes

    Further context: https://github.com/bitcoin/bitcoin/pull/19884/files#r575336503

    Before:

    02021-02-12T17:22:25.980000Z TestFramework (INFO): Test seed peers, this will take about 2 minutes
    12021-02-12T17:24:30.472000Z TestFramework (INFO): Test -networkactive option
    

    After:

    02021-02-12T17:33:39.224000Z TestFramework (INFO): Test seed peers
    12021-02-12T17:33:43.139000Z TestFramework (INFO): Test -networkactive option
    
  2. [refactor] Correct log message in net.cpp 015637dd44
  3. [test] Use mocktime in test_seed_peers()
    Test case now takes < 5 seconds instead of > 2 minutes
    d4187e4619
  4. dhruv commented at 5:51 pm on February 12, 2021: member
    Request #19884 reviewers @LarryRuane @laanwj @jonatack @MarcoFalke to take a look
  5. DrahtBot added the label P2P on Feb 12, 2021
  6. LarryRuane commented at 6:57 pm on February 12, 2021: contributor
    Code review, tested functional test (replaced “65” seconds mock delay with “55” and verified the test fails as expected), ACK e9c037ba64dd5b073fccf059ef75db1c97abd0bd
  7. MarcoFalke merged this on Feb 12, 2021
  8. MarcoFalke closed this on Feb 12, 2021

  9. sidhujag referenced this in commit 6f59df9d7e on Feb 13, 2021
  10. laanwj commented at 9:33 pm on February 14, 2021: member
    Posthumous ACK, thanks!
  11. Fabcien referenced this in commit b9a4c07d59 on Jan 27, 2022
  12. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me