net: make CNode::m_inbound_onion public, initialize explicitly #21167

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:m_inbound_onion-make-public-and-explicit changing 4 files +18 −21

jonatack commented at 10:39 PM on February 12, 2021: member
Refactoring only, no change in behavior. This is a quick follow-up to #20210 to address these review comments:
Changes:
- make the CNode::m_inbound_onion class member public, update the Doxygen comment, drop the getter, and update the tests
- remove the CNode::m_inbound_onion default value initialization in the ctor declaration and the member initializer in favor of always passing it explicitly to the ctor where we initialize it dynamically, to both clarify the caller code and to allow the compiler to warn if it is uninitialized in the ctor or omitted in the caller
net: make CNode::m_inbound_onion public, drop getter, update tests 24bda56c29

net: remove CNode::m_inbound_onion defaults for explicitness

and to allow the compiler to warn if uninitialized in the ctor
or omitted in the caller.

2ee4a7a9ec

DrahtBot added the label P2P on Feb 12, 2021

in src/net.cpp:2863 in 2ee4a7a9ec

2860 |        id(idIn),
2861 |        nLocalHostNonce(nLocalHostNonceIn),
2862 |        m_conn_type(conn_type_in),
2863 | -      nLocalServices(nLocalServicesIn),
2864 | -      m_inbound_onion(inbound_onion)
2865 | +      nLocalServices(nLocalServicesIn)

jonatack commented at 10:44 PM on February 12, 2021:

Argument order changed for -Wreorder initialization order (in this case public members first, then private)

DrahtBot commented at 7:42 AM on February 13, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #21162 (Net Processing: Move RelayTransaction() into PeerManager by jnewbery)
- #21160 (Net/Net processing: Move tx inventory into net_processing by jnewbery)
- #20966 (banman: save the banlist in a JSON format on disk by vasild)
- #20729 (p2p: standardize outbound full/block relay connection type naming by jonatack)
- #20721 (Net: Move ping data to net_processing by jnewbery)
- #20685 (Add I2P support using I2P SAM by vasild)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
vasild approved
vasild commented at 2:11 PM on February 15, 2021: member

ACK 2ee4a7a9ec68c75094685c06ec793b614f44c4ce