Found by Hal Finney (thanks Hal!): change outputs were never inserted as the last output, so were not randomized at all for single-output transactions (they were always the first output). Fixes issue #2107
Fix off-by-one error: change outputs were never last #2120
pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:randomchange changing 1 files +1 −1-
gavinandresen commented at 11:57 PM on December 20, 2012: contributor
-
b682081788
Fix off-by-one error: change outputs were never last
Found by Hal Finney (thanks Hal!): change outputs were never inserted as the last output, so were not randomized at all for single-output transactions (they were always the first output). Fixes issue #2107
-
gavinandresen commented at 12:03 AM on December 21, 2012: contributor
Tested in a testnet-in-a-box setup, sent 10 random 1-ouput transactions (sendtoaddress) and 10 random 2-output transactions (sendmany), then used getrawtransaction to make sure the change outputs were random.
-
BitcoinPullTester commented at 12:14 AM on December 21, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b68208178884d006d16cd0712a89b7abf3e32fbd for binaries and test log.
- gavinandresen closed this on Dec 28, 2012
- owlhooter referenced this in commit 5669fc880e on Oct 11, 2018
- DrahtBot locked this on Sep 8, 2021
