test: Speed up rpc_blockchain.py by removing miniwallet.generate() #21200

1. 
   MarcoFalke commented at 4:51 pm on February 16, 2021: member

   Speed up various tests:

   • Remove unused nodes, which only consume time on start/stop
   • Remove unused “bug workarounds”
   • Remove the need for miniwallet.generate() by adding miniwallet.scan_blocks(). (On my system, with valgrind, generating 105 blocks takes 3.31 seconds. Rescanning 5 blocks takes 0.11 seconds.)
2. test: Start only the number of nodes that are needed faabce7d07
3. test: Remove unused bug workaround fad25153f5
4. test: Cache 25 mature coins for ADDRESS_BCRT1_P2WSH_OP_TRUE fa4d8f3169
5. test: Change address type from P2PKH to P2WSH in rpc_blockchain

   This change does not matter for the test, except that it increases
   the bogosize due to the increase in the size of the scriptPubKey

   fa1fe80c75
6. test: Speed up rpc_blockchain.py by removing miniwallet.generate() faa137eb9e
7. DrahtBot added the label Tests on Feb 16, 2021
8. 
   DrahtBot commented at 0:13 am on February 17, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   laanwj commented at 9:12 am on February 25, 2021: member

   Code review ACK faa137eb9eac5554504b062a6dc865ca87fd572b Thank you for working on speeding up the tests.
10. laanwj merged this on Feb 25, 2021
11. laanwj closed this on Feb 25, 2021

    ---

12. MarcoFalke deleted the branch on Feb 25, 2021
13. sidhujag referenced this in commit eaa732d844 on Feb 25, 2021
14. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke DrahtBot laanwj

Labels
Tests