I don’t think this can be my bug, as I pushed a comment only change to my PR and then got a test failure:
https://cirrus-ci.com/task/5869686954917888?command=ci#L5219
0 test 2021-02-16T19:08:03.550000Z TestFramework (ERROR): Assertion failed
1 Traceback (most recent call last):
2 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 127, in main
3 self.run_test()
4 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_zmq.py", line 82, in run_test
5 self.test_sequence()
6 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_zmq.py", line 277, in test_sequence
7 assert_equal((self.nodes[0].getbestblockhash(), "C", None), seq.receive_sequence())
8 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 50, in assert_equal
9 raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
10 AssertionError: not(('5d2daef0df4c3f8af7d33f350253d3c5b3eab0154803f0f9dff228512ce6ced3', 'C', None) == ('3bd98765bf07cc72a921a5c6fad95b13dac7c80100f0b295f29681e0e3c6e856', 'C', None))
The PR in question needs a rebase anyway now, so I’ll try that and see if this goes away.