Fixes an integer comparison of different signs (which errors out on -Werror,-Wsign-compare). Introduced in #21121.
See https://bitcoinbuilds.org/index.php?ansilog=982c61cf-6969-4001-bebc-dc215e5d29a4.log
test: Avoid comparision of integers with different signs #21228
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2021/02/minertest_U_fix changing 1 files +3 −3-
jonasschnelli commented at 7:37 PM on February 18, 2021: contributor
-
Avoid comparision of integers with different signs bedb8d88bc
- jonasschnelli added the label Tests on Feb 18, 2021
-
MarcoFalke commented at 7:58 PM on February 18, 2021: member
review ACK bedb8d88bcfbfcadcd23e8f3ff4956340fcb028c
unrelated: It would be good to have steps to reproduce for this on Linux (or at least in our ci configs). This is popping up every other week: #19123 , #21159, #19493, #18637 (comment), ...
- MarcoFalke renamed this:
Avoid comparision of integers with different signs
test: Avoid comparision of integers with different signs
on Feb 18, 2021 -
amitiuttarwar commented at 10:50 PM on February 18, 2021: contributor
ACK bedb8d88bcfbfcadcd23e8f3ff4956340fcb028c
do we know the difference between bitcoin builds & our github CI that leads to the warning there but not here?
-
jonasschnelli commented at 7:52 AM on February 19, 2021: contributor
Cirrus mac build has
-werrorfor sign-compare enabled (https://cirrus-ci.com/task/4665160058011648?command=ci#L1296). Could it be due different implementation of boostsequal_impl()? -
MarcoFalke commented at 8:10 AM on February 19, 2021: member
The cross build should be using
depends, which is pinned to a boost and compiler version - vasild approved
-
vasild commented at 9:39 AM on February 19, 2021: member
ACK bedb8d88bcfbfcadcd23e8f3ff4956340fcb028c
- fanquake merged this on Feb 19, 2021
- fanquake closed this on Feb 19, 2021
- sidhujag referenced this in commit f83719ffdb on Feb 19, 2021
- DrahtBot locked this on Aug 16, 2022
