doc: Correction for VerifyTaprootCommitment comments #21246

1. 
   roconnor-blockstream commented at 5:15 pm on February 20, 2021: contributor

   According to BIP-341, ‘p’ is called the taproot internal key, not inner key.
2. DrahtBot added the label Consensus on Feb 20, 2021
3. fanquake requested review from sipa on Feb 21, 2021
4. 
   michaelfolkson commented at 11:56 am on February 21, 2021: contributor

   ACK 56325c9be7a6ea3717efdf2ec5f244a659f26452

   Only three comments in interpreter.cpp that refer to “inner key”, all of them replaced in this PR. No reference to “inner key” in BIP 341

5. 
   theStack commented at 10:53 pm on February 22, 2021: member

   Note that there are also some occurences of “inner pubkey” in the functional taproot test and a test framework script helper module that could be tackled in this PR:

   0$ git grep "inner pubkey"
   1src/script/interpreter.cpp:    //! The inner pubkey (x-only, so no Y coordinate parity).
   2src/script/interpreter.cpp:    // Compute the tweak from the Merkle root and the inner pubkey.
   3src/script/interpreter.cpp:    // Verify that the output pubkey matches the tweaked inner pubkey, after correcting for parity.
   4test/functional/feature_taproot.py:    # The inner pubkey for a taproot script path spend (32 bytes).
   5test/functional/feature_taproot.py:    # The negation flag of the inner pubkey for a taproot script path spend.
   6test/functional/feature_taproot.py:    # Test that bitflips in the inner pubkey invalidate it.
   7test/functional/test_framework/script.py:# - inner_pubkey: the inner pubkey (32 bytes)
   

6. Correction for VerifyTaprootCommitment comments

   According to BIP-341, 'p' is called the taproot *internal* key, not inner key.

   6a0a6e7d05
7. roconnor-blockstream force-pushed on Mar 1, 2021
8. benthecarman approved
9. 
   benthecarman commented at 2:59 pm on March 1, 2021: contributor

   ACK 6a0a6e7d0509e48a6cc08c6604a25671d5f8cab4
10. theStack approved
11. 
    theStack commented at 10:07 pm on March 1, 2021: member

    ACK 6a0a6e7d0509e48a6cc08c6604a25671d5f8cab4
12. MarcoFalke renamed this:
    Correction for VerifyTaprootCommitment comments
    doc: Correction for VerifyTaprootCommitment comments
    on Mar 2, 2021
13. MarcoFalke added the label Docs on Mar 2, 2021
14. 
    DrahtBot commented at 0:25 am on March 5, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21365 (Basic Taproot signing support for descriptor wallets by sipa)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

15. 
    sipa commented at 1:40 am on March 5, 2021: member

    ACK 6a0a6e7d0509e48a6cc08c6604a25671d5f8cab4

    I guess I’ll need to make this change in #21365 as well.

16. fanquake merged this on Mar 5, 2021
17. fanquake closed this on Mar 5, 2021

    ---

18. sidhujag referenced this in commit 0bd2219329 on Mar 5, 2021
19. roconnor-blockstream deleted the branch on Mar 5, 2021
20. DrahtBot locked this on Aug 16, 2022

Contributors
roconnor-blockstream michaelfolkson theStack benthecarman DrahtBot sipa

Review Requested
sipa

Labels
Docs Consensus