break after ProcessMessage() to give other peers a chance. #2125

1. 
   rebroad commented at 2:10 pm on December 23, 2012: contributor

   This is to help with nodes becoming unresponsive in the eyes of other nodes. Also, in combination with my other pulls, this helps to reduce the number of duplicate blocks received.
2. break after ProcessMessages() to give other peers a chance. 7f49bfde58
3. 
   BitcoinPullTester commented at 2:29 pm on December 23, 2012: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.
4. 
   BitcoinPullTester commented at 5:42 am on January 24, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.
5. 
   sipa commented at 0:42 am on April 13, 2013: member

   Can you test whether this is still needed, after the recent network changes?
6. 
   jgarzik commented at 0:43 am on April 13, 2013: contributor

   It seems unneeded, AFAICS
7. 
   sipa commented at 1:36 am on April 13, 2013: member

   Yes, I also don’t see what this should help with, but rebroad seems to have unusual network problems of some sort, so I still wonder whether perhaps those improved because of the recent network changes.
8. 
   rebroad commented at 5:03 am on May 12, 2013: contributor

   @sipa yes, this still is useful after your network changes. This patch is still providing me with valuable functionality - especially when combined with #1382
9. 
   sipa commented at 8:48 am on May 12, 2013: member

   Can you explain what exact difference in behaviour you notice?
10. 
    jgarzik commented at 4:59 pm on May 30, 2013: contributor

    @rebroad Agree w/ @sipa. Please explain precisely what behavior differences and problems are being seen.

    “still useful” is insufficient :)

11. 
    jgarzik commented at 6:31 pm on June 19, 2013: contributor

    Closing. Happy to reopen, if behavior differences can be specifically quantified.
12. jgarzik closed this on Jun 19, 2013

    ---

13. rebroad deleted the branch on Feb 17, 2014
14. DrahtBot locked this on Sep 8, 2021

Contributors
rebroad BitcoinPullTester sipa jgarzik