This is to help with nodes becoming unresponsive in the eyes of other nodes. Also, in combination with my other pulls, this helps to reduce the number of duplicate blocks received.
break after ProcessMessage() to give other peers a chance. #2125
pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:BreakAfterProcessMessage changing 1 files +3 −1-
rebroad commented at 2:10 PM on December 23, 2012: contributor
-
break after ProcessMessages() to give other peers a chance. 7f49bfde58
-
BitcoinPullTester commented at 2:29 PM on December 23, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.
-
BitcoinPullTester commented at 5:42 AM on January 24, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.
-
sipa commented at 12:42 AM on April 13, 2013: member
Can you test whether this is still needed, after the recent network changes?
-
jgarzik commented at 12:43 AM on April 13, 2013: contributor
It seems unneeded, AFAICS
-
sipa commented at 1:36 AM on April 13, 2013: member
Yes, I also don't see what this should help with, but rebroad seems to have unusual network problems of some sort, so I still wonder whether perhaps those improved because of the recent network changes.
-
sipa commented at 8:48 AM on May 12, 2013: member
Can you explain what exact difference in behaviour you notice?
-
jgarzik commented at 6:31 PM on June 19, 2013: contributor
Closing. Happy to reopen, if behavior differences can be specifically quantified.
- jgarzik closed this on Jun 19, 2013
- rebroad deleted the branch on Feb 17, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors