wallet: remove lock during listaddressgroupings #21312

1. 
   vladyslavstartsev commented at 7:47 pm on February 27, 2021: none

   Currently I can’t see how many addresses I have, because when I do listaddressgroupings it locks my wallet. Because it locks the wallet I can’t transfer from my wallet. Stopping the sending from wallet, is not an option for me.

   What I want is to see listaddressgroupings and be able to send from wallet at the same time. Since that, when calling listaddressgroupings you have at least 2 locks that I’ve removed from code. I’ve double checked that GetAddressBalances nor GetAddressGroupings is used in code in any other place except for listaddressgroupings.

2. wallet: remove lock during `listaddressgroupings` 9854504936
3. DrahtBot added the label Wallet on Feb 27, 2021
4. MarcoFalke deleted a comment on Feb 28, 2021
5. MarcoFalke deleted a comment on Feb 28, 2021
6. 
   vladyslavstartsev commented at 8:49 pm on February 28, 2021: none

   any help with fixing CI is welcome
7. 
   MarcoFalke commented at 8:18 am on March 1, 2021: member

   0wallet/wallet.cpp:3398:38: error: reading variable 'mapWallet' requires holding mutex 'cs_wallet' [-Werror,-Wthread-safety-analysis]
   1        for (const auto& walletEntry : mapWallet)
   2                                     ^
   

8. 
   DrahtBot commented at 5:15 am on March 4, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #21207 (MOVEONLY: CWallet transaction code out of wallet.cpp/.h by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   DrahtBot commented at 11:54 am on May 30, 2021: member

   🐙 This pull request conflicts with the target branch and needs rebase.

   Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

10. DrahtBot added the label Needs rebase on May 30, 2021
11. 
    DrahtBot commented at 11:21 am on December 15, 2021: member

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
12. 
    DrahtBot commented at 1:06 pm on March 21, 2022: member

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
13. MarcoFalke closed this on Mar 21, 2022

    ---

14. DrahtBot locked this on Mar 21, 2023

Contributors
vladyslavstartsev MarcoFalke DrahtBot

Labels
Wallet Needs rebase