More robust file/directory syncing and error handling #21313

pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:fsync_dir_pt2 changing 4 files +54 −16
  1. luke-jr commented at 12:38 AM on February 28, 2021: member

    A few more improvements beyond #14501:

    • FileCommit will try multiple sync mechanisms, when supported
    • DirectoryCommit adds Windows support (dropped due to bugs)
    • DirectoryCommit returns success/failure and gets handled as such

    Someone should probably test on BSD, as I recall past directory sync issues

  2. util: Refactor FileCommit so it can try multiple flush mechanisms if one fails 87d5f24404
  3. util: Fall back to fsync() in FileCommit 413841ef8f
  4. luke-jr force-pushed on Feb 28, 2021
  5. luke-jr force-pushed on Feb 28, 2021
  6. DrahtBot added the label Build system on Feb 28, 2021
  7. DrahtBot added the label Utils/log/libs on Feb 28, 2021
  8. luke-jr commented at 1:56 AM on February 28, 2021: member

    Windows port is crashing, no idea how to debug further. Will just remove it unless anyone has some ideas?

  9. util: Return success or failure from DirectoryCommit 67d113c4fc
  10. luke-jr force-pushed on Mar 9, 2021
  11. luke-jr commented at 6:11 PM on March 9, 2021: member

    Dropped Windows port so the rest can move forward.

  12. DrahtBot commented at 10:21 AM on June 8, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25152 (refactor: Split util/system into exception, shell, and fs-specific files by Empact)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  13. achow101 commented at 6:24 PM on October 12, 2022: member

    Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

  14. achow101 closed this on Oct 12, 2022
  15. bitcoin locked this on Oct 12, 2023
Contributors
luke-jrDrahtBotachow101
Labels
Build systemUtils/log/libs
Linked (view graph)
#14501 Fix possible data race when committing block files
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me