Genericide BIP9 in variable/type names and comments #21399

1. 
   luke-jr commented at 8:47 pm on March 9, 2021: member

   (Further splitting up of #19573)

   Most of bcec418304ea3dd524cb3591e4af1b77a04cc968, but mostly converted to a scripted-diff to aid in backporting.

   Hopefully getting this in by itself will make reviewing other PRs simpler.

2. docs: Minor tweaks to genericide versionbits 887aee2ae2
3. scripted-diff: Genericide BIP9 in variable/type names and comments

   -BEGIN VERIFY SCRIPT-
   sed -i -e 's/\bBIP9\b/versionbits/g; s/BIP9/VBits/g; s/bip9\([.()]\)/deployment_details\1/g' $(git grep -il BIP9 src)
   -END VERIFY SCRIPT-

   16cb03c792
4. luke-jr force-pushed on Mar 9, 2021
5. 
   luke-jr commented at 9:02 pm on March 9, 2021: member

   Actually, I wonder if it would be easier overall to just omit all these changes until things have settled?
6. DrahtBot added the label Consensus on Mar 9, 2021
7. DrahtBot added the label Mining on Mar 9, 2021
8. DrahtBot added the label RPC/REST/ZMQ on Mar 9, 2021
9. DrahtBot added the label Validation on Mar 9, 2021
10. 
    DrahtBot commented at 4:38 am on March 10, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21401 (Refactor versionbits deployments to avoid potential uninitialized variables by achow101)
    • #21393 (BIP 341: Add Speedy Trial activation parameters by achow101)
    • #21392 (Implement BIP 8 based Speedy Trial activation by achow101)
    • #21391 ([Bundle 5/n] Prune g_chainman usage in RPC modules by dongcarl)
    • #21380 (versionbits: Refactor and add fuzzing harness by ajtowns)
    • #21378 (Convert taproot to flag day activation by ajtowns)
    • #21377 (Speedy trial support for versionbits by ajtowns)
    • #20556 (rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset) by MarcoFalke)
    • #19438 (Introduce deploymentstatus by ajtowns)
    • #19391 (RPC/Mining: Clean out pre-Segwit miner compatibility code by luke-jr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. DrahtBot added the label Needs rebase on Mar 15, 2021
12. 
    DrahtBot commented at 8:20 am on March 15, 2021: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

13. 
    DrahtBot commented at 4:48 pm on March 15, 2021: member

    🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file.

14. 
    Sjors commented at 9:34 am on March 16, 2021: member

    Concept ACK. I’m also not sure what the right order of merging should be. cc @achow101, @ajtowns
15. luke-jr closed this on May 13, 2021

    ---

16. DrahtBot locked this on Aug 16, 2022

Contributors
luke-jr DrahtBot Sjors

Labels
RPC/REST/ZMQ Mining Validation Consensus Needs rebase